On Tue, 02 Sep 2003, Martin Michlmayr wrote:
> * Goswin von Brederlow <brederlo@informatik.uni-tuebingen.de> [2003-09-02 09:06]:
> > Most (all) the deleted ones had comments by TBM under DAM. Wouldn't
> > a "Frontdeks comments:" part on the NM application be better?
>
> It actually says "Debian Account Manager and Front Desk Comments"
> since this afternoon (UTC +10).
>
> There's also a new "The Front Desk has to review your application"
> item in the "The following things need to happen still" list.
>
> > And for another bold suggestion, maybe an automatic date added when
> > changing comments? Its all in a DB so adding a timestamp field
> > shouldn't be too dificult, right?
>
> So you're volunteering?
Something like the following might be usefull:
Index: newmaint.db
===================================================================
RCS file: /cvs/webwml/newmaint/newmaint.db,v
retrieving revision 1.1.1.1
diff -u -r1.1.1.1 newmaint.db
--- newmaint.db 19 Dec 2000 00:21:06 -0000 1.1.1.1
+++ newmaint.db 2 Sep 2003 21:26:40 -0000
@@ -85,7 +85,17 @@
"am_confirm" bool,
"am_contact" date,
"da_phone_required" bool,
- "application_ok" bool);
+ "application_ok" bool,
+ "last_modified" timestamp with timezone default 'now()');
+CREATE FUNCTION update_last_modified ()
+ RETURNS TRIGGER AS '
+ BEGIN
+ NEW.last_modified := ''now'';
+ RETURN NEW;
+ END;
+' LANGUAGE 'plpgsql';
+CREATE TRIGGER applicant_update_last_modified BEFORE UPDATE ON applicant
+ FOR EACH ROW EXECUTE PROCEDURE update_last_modified();
REVOKE ALL on "applicant" from PUBLIC;
GRANT SELECT on "applicant" to "troup";
GRANT ALL on "applicant" to "csmall";
Index: nmstatus.wml
===================================================================
RCS file: /cvs/webwml/newmaint/nmstatus.wml,v
retrieving revision 1.11
diff -u -r1.11 nmstatus.wml
--- nmstatus.wml 2 Sep 2003 06:12:38 -0000 1.11
+++ nmstatus.wml 2 Sep 2003 21:26:40 -0000
@@ -155,6 +155,15 @@
}
?>
</TD></TR>
+<TR><TD>Time of Last Action</TD><TD>
+<?
+ if (pg_FieldIsNull($query,0,"last_modified")) {
+ echo "Unknown";
+ } else {
+ echo $row["last_modified"];
+ }
+?>
+</TD></TR>
</TABLE>
<?
print_textarea("Application Manager Comments", "man_comment", $row["man_comment"], FALSE);
I haven't really tested this completely, as I didn't have time to
setup a testing environment for the whole nm setup. [But the trigger
and function all work.]
Don Armstrong
--
I don't care how poor and inefficient a little country is; they like
to run their own business. I know men that would make my wife a
better husband than I am; but, darn it, I'm not going to give her to
'em.
-- The Best of Will Rogers
http://www.donarmstrong.com
http://www.anylevel.com
http://rzlab.ucr.edu
Attachment:
pgpIU18SXp16M.pgp
Description: PGP signature