On Sun, 3 Sep 2023 15:52:23 +0200 Cecil Westerhof <
cldwesterhof@gmail.com> wrote:
> On Tue, 13 Jun 2023 00:11:16 +0200 Alban Browaeys <
prahal@yahoo.com> wrote:
> > Package: libdvd-pkg
> > Version: 1.4.3-1-1
> > Followup-For: Bug #994081
> >
> > Dear Maintainer,
> > TL;DR: could apt-get be called with "--dry-run" a flag when we call its
> > "check" command as to get libdvd-pkg triggers script to run?
>
> Why is nothing done with this? Even if it just would have been: this is no
> solution because --dry-run does not what needs to be done?
> I just switched to Debian 12 from 11 and ran into this issue. And when I
> saw that the issue was about two years old I was flabbergasted: I am used
> to the high quality of Debian.
>
> I made in /usr/lib/libdvd-pkg/b-i_libdvdcss.sh the following change:
> # @@@@ added ry-run and /dev/null redirection removed
> apt-get check --dry-run # >/dev/null 2>&1
>
> I am now waiting until my system needs an upgrade to see the result from
> this change.
> I will share it when I have it.
In my /usr/lib/libdvd-pkg/b-i_libdvdcss.sh at line 46, I changed:
apt-get check >/dev/null 2>&1
if [ "$?" -ne 0 ]; then
echo "${PKGI}: \`apt-get check\` failed, you may have broken packages. Aborting..."
exit 0
fi
into:
# @@@@ dry-run toegevoegd en /dev/null redirection verwijderd
echo "BEFORE 'apt-get check' problem"
apt-get check --dry-run # >/dev/null 2>&1
if [ "$?" -ne 0 ]; then
echo "${PKGI}: \`apt-get check\` failed, you may have broken packages. Aborting..."
exit 0
fi
echo "AFTER 'apt-get check' problem"
I had an upgrade that could be done and this resulted in:
BEFORE 'apt-get check' problem
Reading package lists...
Building dependency tree...
Reading state information...
AFTER 'apt-get check' problem
So by adding --dry-run we do not get the error anymore.
So if there is no reason that --dry-run would be wrong, I think it is a good idea to add it: then this two year old problem would finally be solved.