[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1035331: marked as done (jackd2: reproducible-builds: Locale and timezone dependent date in manpages)

Your message dated Thu, 04 May 2023 20:34:22 +0000
with message-id <E1pufeg-00B4VE-Dl@fasolo.debian.org>
and subject line Bug#1035331: fixed in jackd2 1.9.21~dfsg-3
has caused the Debian Bug report #1035331,
regarding jackd2: reproducible-builds: Locale and timezone dependent date in manpages
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1035331: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1035331
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: jackd2
Severity: normal
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: timestamps locale
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

The manpages may contain a locale-translated month name, as well as a
different date based on the build environment timezone.

For jackd.1:

  .TH "JACKD" "1" "January 2023" "1.9.21" ""
  vs.
  .TH "JACKD" "1" "jaanuar 2023" "1.9.21" ""

  .TH "JACKD" "1" "2023-04-30" "1.9.21" ""
  vs.
  .TH "JACKD" "1" "2023-05-01" "1.9.21" ""

The attached patches fix this by using a numeric date specified with the
UTC timezone.

Thanks for maintaining jackd2!

live well,
  vagrant

From 5fe932e274c720b68aff40125f1069fde1490935 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Sun, 30 Apr 2023 15:44:21 -0700
Subject: [PATCH 1/5] man/fill_template: Use numeric year-month-date for
 manpage.

The month may be rendered for the locale of the build environment.

https://reproducible-builds.org/docs/locales/
---
 man/fill_template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/man/fill_template b/man/fill_template
index 368cb1b..d1df18d 100644
--- a/man/fill_template
+++ b/man/fill_template
@@ -4,8 +4,8 @@ d=""
 
 if [ "$2" == "True" ]; then
   for i in *.0 ; do
-    sed -e "s/!VERSION!/${1}/g" -e "s/!DATE!/`date $d '+%B %Y'`/g" < ${i} > ${i%%0}1
+    sed -e "s/!VERSION!/${1}/g" -e "s/!DATE!/`date $d '+%Y-%m-%d'`/g" < ${i} > ${i%%0}1
   done
 else
-  sed -e "s/!VERSION!/${1}/g" -e "s/!DATE!/`date $d '+%B %Y'`/g" < jackd.0 > jackd.1
+  sed -e "s/!VERSION!/${1}/g" -e "s/!DATE!/`date $d '+%Y-%m-%d'`/g" < jackd.0 > jackd.1
 fi
-- 
2.39.2


From 021e05e61bc9ae982063d666de33473e391a0602 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Sun, 30 Apr 2023 15:52:22 -0700
Subject: [PATCH 2/5] man/fill_template: Use UTC date to avoid differences
 based on timezone.

https://reproducible-builds.org/docs/timezones/
---
 man/fill_template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/man/fill_template b/man/fill_template
index d1df18d..641cab8 100644
--- a/man/fill_template
+++ b/man/fill_template
@@ -1,6 +1,6 @@
 #!/bin/sh
 d=""
-[ -z "$SOURCE_DATE_EPOCH" ] || d=--date=@$SOURCE_DATE_EPOCH
+[ -z "$SOURCE_DATE_EPOCH" ] || d="--utc --date=@$SOURCE_DATE_EPOCH"
 
 if [ "$2" == "True" ]; then
   for i in *.0 ; do
-- 
2.39.2

Attachment: signature.asc
Description: PGP signature


--- End Message ---
--- Begin Message --- 
Source: jackd2
Source-Version: 1.9.21~dfsg-3
Done: Nicholas D Steeves <sten@debian.org>

We believe that the bug you reported is fixed in the latest version of
jackd2, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1035331@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Nicholas D Steeves <sten@debian.org> (supplier of updated jackd2 package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Thu, 04 May 2023 15:29:39 -0400
Source: jackd2
Architecture: source
Version: 1.9.21~dfsg-3
Distribution: unstable
Urgency: medium
Maintainer: Debian Multimedia Maintainers <debian-multimedia@lists.debian.org>
Changed-By: Nicholas D Steeves <sten@debian.org>
Closes: 1035308 1035329 1035331
Changes:
 jackd2 (1.9.21~dfsg-3) unstable; urgency=medium
 .
   * Team upload.
   * Import Vagrant Cascadian's reproducible builds patches:
     - Add 0001-man-fill_template-Use-numeric-year-month-date-for-ma.patch.
       Without this patch, manpages may contain a locale-translated month name,
       as well as a different date based on the build environment timezone.
       (Closes: #1035331).
     - Add 0002-man-fill_template-Use-UTC-date-to-avoid-differences-.patch.
       This patch solves variance in generated man page date stamps introduced
       when man pages generated in different timezones are compared to each
       other.
     - Add 0003-man-fill_template-Use-POSIX-compatible-comparison.patch.  When
       built in an environment where /bin/sh -> bash, all of these manpages are
       built and included in the package.  When /bin/sh -> dash, the manpages
       that users depend on are absent from bin:jackd2.
       (Closes: #1035329, #1035308).
Checksums-Sha1:
 e2990c260bed12cae37d040fa3b2428d962e1bbb 2524 jackd2_1.9.21~dfsg-3.dsc
 7015d432481e23d32146f27e1c874fec240eea73 34864 jackd2_1.9.21~dfsg-3.debian.tar.xz
 27f455bc064d01fa445cff7f90faa4d2236bea0b 10030 jackd2_1.9.21~dfsg-3_amd64.buildinfo
Checksums-Sha256:
 1494db8065741543f09a6c345b1f5844b18758679e4d3f04850b7f141455b8c9 2524 jackd2_1.9.21~dfsg-3.dsc
 3901f5784479abdf32fffefd162cea36865b2045f60f1ba1636ca86b48a52894 34864 jackd2_1.9.21~dfsg-3.debian.tar.xz
 456d2ac5319eb238adb6984b9d4b4f172c7bc0f0c795fefecf10addca13d3ec9 10030 jackd2_1.9.21~dfsg-3_amd64.buildinfo
Files:
 b46bf47d77982163baea99f9419a2cd0 2524 sound optional jackd2_1.9.21~dfsg-3.dsc
 c45d589dfeea3f99153e871dc2d09a0a 34864 sound optional jackd2_1.9.21~dfsg-3.debian.tar.xz
 e6f9eb8b5bc955690eaca0fc470c9c74 10030 sound optional jackd2_1.9.21~dfsg-3_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE4qYmHjkArtfNxmcIWogwR199EGEFAmRUC+kACgkQWogwR199
EGHovA//WGsWH0LYoQsHtP0FZi0Y4VOTTKI3UvzunIDnhWIk8K4/jFC4VdMG7gm9
fTbW5sI+vjsKxOvnKbBwClMV+wW0Jab6OtW1ET1Gu1CznBr6AH08dx8hX+cHVHQU
YSCpjepCqtw2icFTjpMiFpg6FtlT0QZD0gXfS5QXTpq1EJMBE2V5vd/kjkINcEbQ
whDbxtwzpqdZjYrfytCcQNR/Qus0ppcYwA6kjeUoBcJtQndjIzWGvCXIF3SVeWMW
g900EWMJgp0padA3KgP7bFy3EYfepysVhDbxIXcGPpZqS0t5pGvywLd29Go488Y0
zdAwe0sUrt89TQpt7yjtjvjeLjxtzkdBrE+o9LVMdsD0HeGZkF1TB9Rya/noOZ+j
+ROqqxCoItGlyYs2IQxZKU1vEYmVd9onvEZJp+afD8opzexBg/OrdkJCOC/ZhfY7
2erDOyiBD1GWqtPD5lfdrDWd3TOsuIqTIw30IlaAlra4MGUl7NEvhnN9Ptbdt1rb
cqk0Ucy8d8LP9sWJjTFs5S5EREtsCekYr1gXqFoXoYoZY1DGQx8iYpw4ogocg4Tz
xchnGxstbYzWPBUSArMWP4HCLPnzc5PhqkCZvHNqX+f2B0iXcSZsxlQuoi00rGRV
Yi2Cbc8AwchnBLEt4Z/WH3n9GEbHi6Rb40P9z02AGRuDUp6X6+Y=
=Yvlo
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: