Bug#919173: marked as done (tutka FTBFS on architectures where char is unsigned)
Your message dated Sat, 19 Jan 2019 01:23:54 +0000
with message-id <E1gkfMY-0004YF-7d@fasolo.debian.org>
and subject line Bug#919173: fixed in tutka 1.1.2-2
has caused the Debian Bug report #919173,
regarding tutka FTBFS on architectures where char is unsigned
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)
--
919173: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=919173
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Source: tutka
Version: 1.1.2-1
Severity: important
Tags: ftbfs
https://buildd.debian.org/status/package.php?p=tutka&suite=sid
...
tracker.cpp: In member function 'virtual void Tracker::keyPressEvent(QKeyEvent*)':
tracker.cpp:992:22: error: comparison is always true due to limited range of data type [-Werror=type-limits]
if (data >= 0) {
~~~~~^~~~
tracker.cpp:1030:26: error: comparison is always true due to limited range of data type [-Werror=type-limits]
if (data >= 0) {
~~~~~^~~~
tracker.cpp:1055:26: error: comparison is always true due to limited range of data type [-Werror=type-limits]
if (data >= 0) {
~~~~~^~~~
tracker.cpp:1127:18: error: comparison is always true due to limited range of data type [-Werror=type-limits]
if (note >= 0 && cursorItem_ == 0) {
~~~~~^~~~
player.cpp: In member function 'void Player::playNote(unsigned int, unsigned char, unsigned char, unsigned char, bool)':
player.cpp:237:31: error: comparison is always true due to limited range of data type [-Werror=type-limits]
if (trackStatus->note != -1) {
~~~~~~~~~~~~~~~~~~^~~~~
player.cpp:254:37: error: comparison is always false due to limited range of data type [-Werror=type-limits]
if (trackStatus->volume < 0) {
~~~~~~~~~~~~~~~~~~~~^~~
player.cpp: In member function 'void Player::stopMuted()':
player.cpp:278:35: error: comparison is always true due to limited range of data type [-Werror=type-limits]
if (trackStatus->note != -1) {
~~~~~~~~~~~~~~~~~~^~~~~
player.cpp: In member function 'void Player::stopNotes()':
player.cpp:294:31: error: comparison is always true due to limited range of data type [-Werror=type-limits]
if (trackStatus->note != -1) {
~~~~~~~~~~~~~~~~~~^~~~~
player.cpp: In member function 'virtual void Player::run()':
player.cpp:629:66: error: comparison is always true due to limited range of data type [-Werror=type-limits]
if (arpeggioInstrument >= 0 && trackStatus->line >= 0) {
~~~~~~~~~~~~~~~~~~^~~~
player.cpp:669:47: error: comparison is always true due to limited range of data type [-Werror=type-limits]
if (trackStatus->note != -1) {
~~~~~~~~~~~~~~~~~~^~~~~
player.cpp:757:64: error: comparison is always true due to limited range of data type [-Werror=type-limits]
if (trackStatus->hold < 0 && trackStatus->note != -1) {
~~~~~~~~~~~~~~~~~~^~~~~
player.cpp:780:70: error: comparison is always true due to limited range of data type [-Werror=type-limits]
if (arpeggioInstrument >= 0 && trackStatus->baseNote >= 0 && trackStatus->line >= 0) {
~~~~~~~~~~~~~~~~~~~~~~^~~~
player.cpp:780:96: error: comparison is always true due to limited range of data type [-Werror=type-limits]
if (arpeggioInstrument >= 0 && trackStatus->baseNote >= 0 && trackStatus->line >= 0) {
~~~~~~~~~~~~~~~~~~^~~~
cc1plus: all warnings being treated as errors
make[2]: *** [Makefile:989: .obj/tracker.o] Error 1
These are real bugs, using -1 as special value and
then comparing >= 0 does not work on unsigned variables.
--- End Message ---
--- Begin Message ---
Source: tutka
Source-Version: 1.1.2-2
We believe that the bug you reported is fixed in the latest version of
tutka, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 919173@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Gürkan Myczko <gurkan@phys.ethz.ch> (supplier of updated tutka package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Wed, 16 Jan 2019 21:16:12 +0100
Source: tutka
Binary: tutka
Architecture: source
Version: 1.1.2-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Multimedia Maintainers <debian-multimedia@lists.debian.org>
Changed-By: Gürkan Myczko <gurkan@phys.ethz.ch>
Description:
tutka - tracker style MIDI sequencer
Closes: 919173
Changes:
tutka (1.1.2-2) unstable; urgency=medium
.
* Apply upstream patch, to fix FTBFS on architectures where char is
unsigned (Closes: #919173).
Checksums-Sha1:
2df324a60f585f589cf9fbfe152c4255a74eea7a 1805 tutka_1.1.2-2.dsc
bb7dcb2a269f76c3549e90e2505356bc8e8c36d9 3004 tutka_1.1.2-2.debian.tar.xz
5782a0640170b2cbbacfc2400ee4602f7e9584cd 4881 tutka_1.1.2-2_source.buildinfo
Checksums-Sha256:
ec004e296558dbf0330874c2d3a2353d86f8bc64a4cdff572fbd191d89d5499a 1805 tutka_1.1.2-2.dsc
4163092d14ed194e609c1a0433bae49d2c941d09c4b260ae825a47b0f11fc8c6 3004 tutka_1.1.2-2.debian.tar.xz
76867666e16b911417633c7d6eec3551e547ea53948f62be10c1532f14184762 4881 tutka_1.1.2-2_source.buildinfo
Files:
6412ab2d31024bde62633c7bbbec4e16 1805 sound optional tutka_1.1.2-2.dsc
006bbe09be80e34a4373e7f23daf8fc3 3004 sound optional tutka_1.1.2-2.debian.tar.xz
d7511d0f1fc9f5b8f88a288758342a48 4881 sound optional tutka_1.1.2-2_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEEkjZVexcMh/iCHArDweDZLphvfH4FAlxCdsAACgkQweDZLphv
fH5dlhAAzKrYgaCmc0ydfsoLnSQSsWGeGwAYvaCu5q/EzZwkJexuAKfBE33midCo
wRk0P1allU1ZK+rPtwkVwPXB8hGMNUe0X2R32P/NOvvu1m5qJPNdQgeWnh63t9eo
MsOjGt3HlB16rGCg/eOExHKwGj7naMbyBK6jZbLBP3ottl9pQ9BLrRQol7uBQMTQ
x6qkPAbYabx7CXC+hhC4hCxs1pgDjuxCsGc+WOTEfys4GGq8LjAnk4YgbscdFvL7
cU+WttiG58QKg7/UM37IFjhAt0YHeqAcaWXNC7DyJ+3hZxwy+ZO1OOKVca523g7l
NzAjd7Qo3876LpLepB/z0SEejJgDawccVMbQLmXTaqtdRwxQsBMMqi7/OqqVi0P2
9pk8zEQtcMU7u/Mj+qatpFSe+x1UJiyKx0oB0oGi+1q+rdX/Oi9xdWSs3DzpOlbv
CKnxHNlTXLP6X4P0JN3zQi9oiQAlUoxwafn+Ljnyq6EY/pO6Fn1vL3aY4oBPZRbb
/7pJlfEJ9ngwqBBdfDtbcC+crvU+x5pkV+BGFSoBjdk9UH3jj8Iy5rMmIeyBmwJy
r2ynKN0GuCLUqHT4WOUt66z5ejWnAejLQSlLbO/rIQHK7qejmxb1B2qlVqlmfYYx
aoRkcJjUfaLyMPK7hTmimiL1R5x+QOX+m7dC2QdM7GdNLowZjtw=
=zwXL
-----END PGP SIGNATURE-----
--- End Message ---
Reply to: