Bug#919173: tutka FTBFS on architectures where char is unsigned
Source: tutka
Version: 1.1.2-1
Severity: important
Tags: ftbfs
https://buildd.debian.org/status/package.php?p=tutka&suite=sid
...
tracker.cpp: In member function 'virtual void Tracker::keyPressEvent(QKeyEvent*)':
tracker.cpp:992:22: error: comparison is always true due to limited range of data type [-Werror=type-limits]
if (data >= 0) {
~~~~~^~~~
tracker.cpp:1030:26: error: comparison is always true due to limited range of data type [-Werror=type-limits]
if (data >= 0) {
~~~~~^~~~
tracker.cpp:1055:26: error: comparison is always true due to limited range of data type [-Werror=type-limits]
if (data >= 0) {
~~~~~^~~~
tracker.cpp:1127:18: error: comparison is always true due to limited range of data type [-Werror=type-limits]
if (note >= 0 && cursorItem_ == 0) {
~~~~~^~~~
player.cpp: In member function 'void Player::playNote(unsigned int, unsigned char, unsigned char, unsigned char, bool)':
player.cpp:237:31: error: comparison is always true due to limited range of data type [-Werror=type-limits]
if (trackStatus->note != -1) {
~~~~~~~~~~~~~~~~~~^~~~~
player.cpp:254:37: error: comparison is always false due to limited range of data type [-Werror=type-limits]
if (trackStatus->volume < 0) {
~~~~~~~~~~~~~~~~~~~~^~~
player.cpp: In member function 'void Player::stopMuted()':
player.cpp:278:35: error: comparison is always true due to limited range of data type [-Werror=type-limits]
if (trackStatus->note != -1) {
~~~~~~~~~~~~~~~~~~^~~~~
player.cpp: In member function 'void Player::stopNotes()':
player.cpp:294:31: error: comparison is always true due to limited range of data type [-Werror=type-limits]
if (trackStatus->note != -1) {
~~~~~~~~~~~~~~~~~~^~~~~
player.cpp: In member function 'virtual void Player::run()':
player.cpp:629:66: error: comparison is always true due to limited range of data type [-Werror=type-limits]
if (arpeggioInstrument >= 0 && trackStatus->line >= 0) {
~~~~~~~~~~~~~~~~~~^~~~
player.cpp:669:47: error: comparison is always true due to limited range of data type [-Werror=type-limits]
if (trackStatus->note != -1) {
~~~~~~~~~~~~~~~~~~^~~~~
player.cpp:757:64: error: comparison is always true due to limited range of data type [-Werror=type-limits]
if (trackStatus->hold < 0 && trackStatus->note != -1) {
~~~~~~~~~~~~~~~~~~^~~~~
player.cpp:780:70: error: comparison is always true due to limited range of data type [-Werror=type-limits]
if (arpeggioInstrument >= 0 && trackStatus->baseNote >= 0 && trackStatus->line >= 0) {
~~~~~~~~~~~~~~~~~~~~~~^~~~
player.cpp:780:96: error: comparison is always true due to limited range of data type [-Werror=type-limits]
if (arpeggioInstrument >= 0 && trackStatus->baseNote >= 0 && trackStatus->line >= 0) {
~~~~~~~~~~~~~~~~~~^~~~
cc1plus: all warnings being treated as errors
make[2]: *** [Makefile:989: .obj/tracker.o] Error 1
These are real bugs, using -1 as special value and
then comparing >= 0 does not work on unsigned variables.
Reply to: