[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#909820: marked as done (pd-mrpeach: d/rules have build steps that are "hidden" no ops)

Your message dated Sat, 29 Sep 2018 19:35:54 +0000
with message-id <E1g6L1u-0003kr-5u@fasolo.debian.org>
and subject line Bug#909820: fixed in pd-mrpeach 0.1~svn17647-3
has caused the Debian Bug report #909820,
regarding pd-mrpeach: d/rules have build steps that are "hidden" no ops
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
909820: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=909820
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: pd-mrpeach
Version: 0.1~svn17647-2
Severity: serious

Hi,

Due to a recent change in debhelper, we learning that pd-mrpeach have a
build step that seems like it ought to do something but in fact does
nothing.


In d/rules we find this:
"""
override_dh_auto_install:
	dh_auto_install -- prefix=/usr pkglibdir=$(pkglibdir)
# fix permissions
	find $(CURDIR)/debian/pd-*/ -name "*.pd_linux" -exec \
		chmod 0664 {} +
# replace license file with link to the Debian license file
	rm -f -- $(CURDIR)/debian/$(PACKAGE)/$(pkglibdir)/$(LIBRARY_NAME)/LICENSE.txt
"""

The dh_auto_isntall call creates debian/*tmp* rather than
debian/*${pkg}* when d/control lists multiple binary packages.
Accordingly, both the "find" and the "rm -f" calls matches nothing.

This became apparent when I changed debhelper to avoid creating empty
directories for packages a head of time as that makes the find call
error out[1].

Please evaluate whether the code bits are still relevant and either:

 * remove them if they are obsolete.
 * change them to apply their changes to debian/tmp
 * move them to a later step where they can be applied correctly.

On a related note: it is not clear to me that the chmod 0664 surives
past dh_fixperms at the moment.

I have filed this as serious against pd-mrpeach on the assumption that
the chmod change is important.  If it is no longer revelevant, then
this bug can be downgraded to minor (please remember to CC me if you
do that as I will have to update debhelper to undo some code).

Thanks,
~Niels

[1]: https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/pd-mrpeach.html

--- End Message ---
--- Begin Message --- 
Source: pd-mrpeach
Source-Version: 0.1~svn17647-3

We believe that the bug you reported is fixed in the latest version of
pd-mrpeach, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 909820@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
IOhannes m zmölnig (Debian/GNU) <umlaeute@debian.org> (supplier of updated pd-mrpeach package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sat, 29 Sep 2018 21:03:03 +0200
Source: pd-mrpeach
Binary: pd-mrpeach pd-osc pd-cmos pd-mrpeach-net pd-slip pd-xbee
Architecture: source
Version: 0.1~svn17647-3
Distribution: unstable
Urgency: medium
Maintainer: Debian Multimedia Maintainers <debian-multimedia@lists.debian.org>
Changed-By: IOhannes m zmölnig (Debian/GNU) <umlaeute@debian.org>
Description:
 pd-cmos    - digital logic emulator objects for Pure Data (Pd)
 pd-mrpeach - bag of tricks for Pure Data (Pd)
 pd-mrpeach-net - Pd library for low-level networking
 pd-osc     - Open Sound Control for Pd
 pd-slip    - SLIP encoder/decoder for Pure Data (Pd)
 pd-xbee    - interfacing with your XBee from within Pure Data (Pd)
Closes: 909820
Changes:
 pd-mrpeach (0.1~svn17647-3) unstable; urgency=medium
 .
   * dh_auto_install fixes (Closes: #909820)
     * Remove all LICENSE.txt files during dh_auto_install
     * Drop executable-bit from all .pd_linux files in the package
     * Dropped group-writable bit from all .pd_linux files (fixed typo)
   * Don't require "root" for building
   * Bumped standards version to 4.2.1
Checksums-Sha1:
 51dc09bcd4d66ef57e478c2d5084b953d77243c3 2317 pd-mrpeach_0.1~svn17647-3.dsc
 e5a4ce8461be0763dbdb7be3627429f5bb836942 22252 pd-mrpeach_0.1~svn17647-3.debian.tar.xz
 e8ebef4ca3c6b51da1d8a8941890d193c18a62a7 9242 pd-mrpeach_0.1~svn17647-3_amd64.buildinfo
Checksums-Sha256:
 3ba0d3470dafae2036cefff371c93783ae4693ec02ebd797b30f20783589272c 2317 pd-mrpeach_0.1~svn17647-3.dsc
 5b645c61de29fb631930c6c096584868fd0c30b2748987b0d97f328c40f67457 22252 pd-mrpeach_0.1~svn17647-3.debian.tar.xz
 86348f606cc2b14dffec2a8f368e85abd593c93f86bd2f418345ceeb8e778d24 9242 pd-mrpeach_0.1~svn17647-3_amd64.buildinfo
Files:
 f0041dbb91d2bd8cdd28638b7accaee9 2317 sound optional pd-mrpeach_0.1~svn17647-3.dsc
 dfb00d3934b71bdd903da91ae888544e 22252 sound optional pd-mrpeach_0.1~svn17647-3.debian.tar.xz
 ed43071cda00719a6cc8ac3b3c480c0e 9242 sound optional pd-mrpeach_0.1~svn17647-3_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEdAXnRVdICXNIABVttlAZxH96NvgFAluvzNQACgkQtlAZxH96
NvgoNw/9Hfv9WDGtylNAwySWcK7KrGk5bJMmPblaEFUy6PEuEfqiM2J/S9H6t+R6
s7Y6XhW2ptq5sySaTfmcNGVRwzwmEBTjRwVgftid7Sc4SIrG3sf5Ogm7WnsLGof1
Po1UN3OVa1yJ+vq0sVwU/K5KN/Ox4Wtn+IlHRSBSS4ZIHY9UP53XDJHgL4hbNUKV
sUcEvEJrpmDzGvAirjDKh4Ts5oP8qCJSmAp2zLEJUFLwBoHCY6Djb6C80aZnegTa
U/VvxQ7k6JZJGqkhx35j+kxh8CzgXtVghhU58mbhOg8CmIDdZAoNubsx3jOYtAP3
HmJ6OABnjCglkOmI5xWd23sXAQb5wYZmWrh80zFcChwBo4Ttv8ZYfSHp1v040bjc
HD7fhhOE13dxSqkr4nvbtgJBpIbi4enkPltic2v8+O90ZpaBz6x3Rc0/xJ/pH44R
qztWEPAn5WSqGtie+hqTXyDNsdsPYpBBh3k16xhp0+U9JzQG2jLbOkqCmpYfUQtp
UDhD4RTjbdLq6B4XzRYF/+fjNFLDnRfJPyY6RfPULC5APwmBexbbxmcEtjG7IJDt
Y05o7rS/K4Ca9cTQ3rsXAPnJnE2bXSy2+xza/VrMPXsn8840iRdL6uQ8Q7cd1p1b
44RRNSAk5AWSA12yYeI/vNRGR/kplp7kmuSxw3xm2Q1L3uqsj1I=
=xuZZ
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: