Bug#909820: pd-mrpeach: d/rules have build steps that are "hidden" no ops

[Niels Thykier <niels@thykier.net>]

Source: pd-mrpeach
Version: 0.1~svn17647-2
Severity: serious

Hi,

Due to a recent change in debhelper, we learning that pd-mrpeach have a
build step that seems like it ought to do something but in fact does
nothing.


In d/rules we find this:
"""
override_dh_auto_install:
	dh_auto_install -- prefix=/usr pkglibdir=$(pkglibdir)
# fix permissions
	find $(CURDIR)/debian/pd-*/ -name "*.pd_linux" -exec \
		chmod 0664 {} +
# replace license file with link to the Debian license file
	rm -f -- $(CURDIR)/debian/$(PACKAGE)/$(pkglibdir)/$(LIBRARY_NAME)/LICENSE.txt
"""

The dh_auto_isntall call creates debian/*tmp* rather than
debian/*${pkg}* when d/control lists multiple binary packages.
Accordingly, both the "find" and the "rm -f" calls matches nothing.

This became apparent when I changed debhelper to avoid creating empty
directories for packages a head of time as that makes the find call
error out[1].

Please evaluate whether the code bits are still relevant and either:

 * remove them if they are obsolete.
 * change them to apply their changes to debian/tmp
 * move them to a later step where they can be applied correctly.

On a related note: it is not clear to me that the chmod 0664 surives
past dh_fixperms at the moment.

I have filed this as serious against pd-mrpeach on the assumption that
the chmod change is important.  If it is no longer revelevant, then
this bug can be downgraded to minor (please remember to CC me if you
do that as I will have to update debhelper to undo some code).

Thanks,
~Niels

[1]: https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/pd-mrpeach.html