[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

potential bug in menu (Debian testing)



Hi,

While trying to upgrade my mipsel board to sarge from woody today I
noticed lots of errors from /usr/bin/update-menus.  They fit exactly
the problems described in the closed bug #127921 at 
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=127921

I see that the "menu" package in sarge has the -static workaround
applied to menu-2.1.5/debian/rules that is recommended in that bug
report.  However, it seems to be wrong.  When I rebuild that package
it still uses CXXFLAGS="-O2 -Wall" CFLAGS="-O2 -Wall" on my mipsel
box.  By my estimation, the ifneq should be a ifeq, like:


--- menu-2.1.5/debian/rules.orig        2003-02-13 19:18:24.000000000 -0600
+++ menu-2.1.5/debian/rules     2003-02-13 19:18:31.000000000 -0600
@@ -13,7 +13,7 @@
 # But debian policy says to compile with -O2 (also it really
 # does speed up runtime: about 2--3 times as fast).
 arch    := $(shell dpkg --print-architecture)
-ifneq ($(findstring $(arch),arm mips),)
+ifeq ($(findstring $(arch),arm mips),)
 # Static linking works around some toolchain issue on mips. Bug #127921
 # ARM seems to have the same problem
 CXXFLAGS = -O2 -Wall -static
yeager:~/dl/linux/debian/menu/mipsel% mutt -f =debian-mips

With this one character change, my rebuilt menu package correctly
uses CXXFLAGS="-O2 -Wall -static" CFLAGS="-O2 -Wall -static".

Or am I missing something?  With the -static rebuilt exe,
/usr/bin/update-menus doesn't crash with an illegal instruction
anymore.

Thanks,
Dan



Reply to: