Bug#1034168: RFS: profile-cleaner/2.44-1 [ITP] -- Reduces browser profile size by cleaning their sqlite databases
On Thu, May 25, 2023 at 12:45:12PM +0100, Peter B wrote:
> On 24/05/2023 22:04, Tobias Frost wrote:
> > Package: sponsorship-requests
> > Followup-For: Bug #1034168
> > Control: tags -1 moreinfo
> >
> > Hi Peter,
> >
> > some review:
> > - d/postinst is not a place to post messages to users;
> What do you suggest then? I could ditch the postinst and put the text
> into the man page, but users are probably less like to see it.
maintainer scripts are not designed to convey messages to users.
It is very liekly to be not seen at all, and the one performing the
installatin might not be the user using it later or the user might
not remember the warning when actually using the software…
Even writing in the manpage is in my opinion not really suitable,
IMHO the program itself needs to ensure that there is no data loss,
e.g by detecting if the programm in question is currently being
executed and if it detects it refuse to its thing or lock the database,
(if that prevents that.)
> Note, this is upstream's postinst, not something I added myself.
Well, if upstream ships a posinst that is not suitable, it cannot be
used…
>
> > also is does
> > not have the #DEBHELPER# token. dh_installdeb(1)
> > (For that, the lintian override is wrong too)
> Oops. Fixed, and removed the override
>
> >
> > doc/pc.1 says:
> > ".\" Text automatically generated by txt2man"
> >
> > It seems that the source is missing (the input file for txt2man)?
> > It would be nice to have this and create the manpage at build time.
> > (Can you ask upstream to include the source file of the manpage?)
>
> Raised upstream
> https://github.com/graysky2/profile-cleaner/issues/39
>
>
> Thanks for your review.
> Uploaded the latest upstream version 2.45 to Mentors
> https://mentors.debian.net/package/profile-cleaner/
Thanks for bulding it now!
--
tobi
Reply to: