Bug#1011377: RFS: ngraph-gtk/6.09.06-1 -- create scientific 2-dimensional graphs
Control: tags 1011377 - moreinfo
Thank you for the review.
I have fixed the problems.
> * copyright:
> + CC0-1.0 is in common-licenses, no need to have the full license
> text verbatim in d/copyright
remove full license text and add location of the license text.
> + src/gettext.h is under LGPL, not GPL
fixed.
> + missing copyright holders and license info for various files under
> src/gtk/* (at least sourcecompletionwords.*, ruler.c)
add license informations for sourcecompletionwords.* and gtk_ruler.c.
> * control: this combination of build-deps makes no sense: debhelper
> (>= 12.0.0), debhelper-compat (= 13); you probably want to remove
> the (leftover?) debhelper one
remove debhelper (>= 12.0.0).
> * docs: README and NEWS files aren't useful as documentation (the
> former only mentions the project's homepage, already documented in
> the packaging; the latter is but a list of released versions)
README and NEWS are removed from docs.
> Nitpicking:
> * changelog: entry about AC_CHECK_FILE concerns an upstream rather
> than a debian packaging change
the entry is removed.
> * rules: could make use dh_bash-completion or "execute_after" instead
> of an override
use dh_bash-completion instead of override_dh_auto_install.
I have uploaded revised packages to mentors.debian.org.
Reply to: