Control: tags -1 moreinfo
On Sat, 21 May 2022 18:42:21 +0900 (JST)
Hiroyuki Ito <ZXB01226@nifty.com> wrote:
> I am looking for a sponsor for my package ngraph-gtk:
hi Hiroyuki,
A couple of issues:
* copyright:
+ CC0-1.0 is in common-licenses, no need to have the full license
text verbatim in d/copyright
+ src/gettext.h is under LGPL, not GPL
+ missing copyright holders and license info for various files under
src/gtk/* (at least sourcecompletionwords.*, ruler.c)
* control: this combination of build-deps makes no sense: debhelper
(>= 12.0.0), debhelper-compat (= 13); you probably want to remove
the (leftover?) debhelper one
* docs: README and NEWS files aren't useful as documentation (the
former only mentions the project's homepage, already documented in
the packaging; the latter is but a list of released versions)
Nitpicking:
* changelog: entry about AC_CHECK_FILE concerns an upstream rather
than a debian packaging change
* rules: could make use dh_bash-completion or "execute_after" instead
of an override
Please remove the moreinfo tag (and CC me directly) once you have an
updated package ready.
Attachment:
pgp6vSoYw5Vem.pgp
Description: OpenPGP digital signature