Bug#990235: RFS: python-pylatexenc/2.10-1 [ITP] -- Simple LaTeX parser providing conversion to/from unicode

["Diego M. Rodriguez" <diego@moreda.io>]

Control: tags 990235 - moreinfo

Hello Jeroen,

thanks for the review and detailed reply:

On Fri, Aug 27, 2021, at 12:59, Jeroen Ploemen wrote:
> * The lintian hits on the binary pkg deserve an override:

Added two overrides - they are more vague than I would have liked, as it seems that the order in which the offending files are displayed in the warnings is not deterministic. The other alternative seemed to be adding 3x2 individual ones, but resulted in "mismatched-override" warnings.

> * Changelog: just the 'Initial release' line closing the ITP bug will do
>   for a new package.

Fixed the changelog, leaving the "Initial release" line.

> * Control: why the old compat level 12?

Likely it was the one I added when starting packaging a long time ago - bumped to 13.

> * Copyright: there's no mention of any copyright later than 2019 held by
>   Philippe Faist, yet grepping the upstream sources shows entries as
>   recent as 2021 for that person.

Thanks for catching these as well. I added explicit lines to d/copyright for the files that declare a copyright year different than the one declared in LICENSE.txt.

> * Rules: what is the override of dh_auto_clean trying to achieve?

Helping me clean up the package locally in previous iterations :) Removed, as indeed it was a leftover.

> * Rules: the help2man target seems to require an installed package in
>   order to succeed. Any way to make this work with just the extracted
>   source package? If not, a comment documenting the requirement would be
>   useful.

I could not find a sensible way to make it work - updated the comment in d/rules in the hopes of making it more explicit.

> * Tests: please add non-trivial autopkgtests, based on the upstream
>   testsuite.

Added, thanks again for the example.

> Please remove the moreinfo tag (and CC me directly) once you have an
> updated package ready.

Ditto - hopefully the latest version in salsa is ready for a new review.

Best,
---
Diego M. Rodriguez