[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#990235: RFS: python-pylatexenc/2.10-1 [ITP] -- Simple LaTeX parser providing conversion to/from unicode



Control: tags -1 moreinfo

On Wed, 23 Jun 2021 18:05:05 +0200
"Diego M. Rodriguez" <diego@moreda.io> wrote:

> Package: sponsorship-requests
> Severity: wishlist
> 
> Dear mentors,
> 
> I am looking for a sponsor for my package "python-pylatexenc":

Hi Diego,

this package looks quite nice overall, and I like that you've put the
salsa CI features to good use too. Couple of questions and (mostly easily
fixable) issues though:

* The lintian hits on the binary pkg deserve an override:
  X: python3-pylatexenc: application-in-library-section python usr/bin/latexwalker usr/bin/latexencode usr/bin/latex2text
  X: python3-pylatexenc: library-package-name-for-application usr/bin/latexwalker usr/bin/latexencode usr/bin/latex2text

* Changelog: just the 'Initial release' line closing the ITP bug will do
  for a new package. That will probably also stop mentors from
  complaining about "Package closes bugs in a wrong way".

* Control: why the old compat level 12?

* Copyright: I did initially have my doubts about _uni2latexmap_xml.py
  being subject to both Expat and W3C, but looking at -legal you did your
  homework there and came to a reasonable conclusion.
* Copyright: there's no mention of any copyright later than 2019 held by
  Philippe Faist, yet grepping the upstream sources shows entries as
  recent as 2021 for that person.

* Rules: what is the override of dh_auto_clean trying to achieve?
* Rules: the help2man target seems to require an installed package in
  order to succeed. Any way to make this work with just the extracted
  source package? If not, a comment documenting the requirement would be
  useful.

* Tests: please add non-trivial autopkgtests, based on the upstream
  testsuite. Be sure to copy the tests out of the source dir and to loop
  over all supported python3 versions; there's plenty of packages on the
  python team repo that can serve as examples, including [1].


Please remove the moreinfo tag (and CC me directly) once you have an
updated package ready.


[1] https://salsa.debian.org/python-team/packages/puremagic/-/tree/master/debian/tests

Attachment: pgpKsYhYVjthx.pgp
Description: OpenPGP digital signature


Reply to: