[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#988346: RFS: fpart/1.3.0-1

Control: tags -1 moreinfo

Hi Ganael,

> Changes since the last upload:
>     Import Debian changes 1.3.0-1
>     fpart (1.3.0-1) unstable; urgency=low
>       * New upstream release
>       * debian/control
>         - Bump Standards-Version to 4.5.1 (no changes required)
>         - Add mailx to Depends

Well, Debian is frozen – it is strongly discouraged to upload inapproppiate [1]
changes to unstable at this time.

[1] https://release.debian.org/bullseye/freeze_policy.html

So you should either target experimental or wait until bullseye is released.

(Below is assuming to either to wait or target experimental; Because of the
potential mess a upload to sid might create, I generally do not upload to sid
if it is clearly outside of [1])

BTW, did you check if #834328 is still there?

As you are upstream -- Regarding the new upstream version: (not needed to be
fixed right now, but maybe 1.4.0 :))
  - please do not package the autom4te.cache directory in tarball. (those files
    are ~1/2 MB and system-specific, so not useful in a source distribution
  - please consider signing your tarballs and do signature checking in d/watch.

Are the new docs under docs/www.fparts.org some docs that are useful to be
installed as well?

One of those, index.md says:
# Contributions

FTS code comes from FreeBSD :

    lib/libc/gen/fts.c -> fts.c
    include/fts.h      -> fts.h

Two things on that
- The paths do not match the source tree. (it is in src/)
- That is not documented in d/copyright… (needs a own section)

(Please review your d/copyright to make sure everything is 100% correct:
e.g I see you say BSD-3-clause in d/copyright for your files; one file
  I've openened randomly was BSD-2-claue).

Any reasons not to go for compat level = 13?

Some linitan stuff. No need to fix them, but it would make the
package more beatiful:

X: fpart source: debian-watch-does-not-check-gpg-signature
  -- see above

P: fpart source: package-uses-old-debhelper-compat-version 12
  -- see above

P: fpart source: silent-on-rules-requiring-root
  -- easy to fix

X: fpart source: upstream-metadata-file-is-missing
  -- see https://wiki.debian.org/UpstreamMetadata.
     (possibly use codesearch.d.n for examples)


Attachment: signature.asc
Description: PGP signature

Reply to: