tags 979274 moreinfo thanks Hi Olivier, Thanks for packaging sfizz. Here is a first review. d/changelog: 1. As sfizz is brand new for Debian, the changelog should only contain one entry saying "Initial release (Closes: etc.". Please delete all of the earlier iterations of test versions in the changelog. d/control: 2. Has Jean Pierre Cimalando (upstream author) agreed to co-maintain the package in Debian? He is one of the upstream authors, so I assume he might be interested in receive bug mail. But that can also be achieved by subscribing to the package on the package tracker. 3. If this package is being maintained in the Debian Multimedia Team, the git repository should be listed in a VCS field. 4. The long description could be improved. The one sentence could be two. The second is not grammatically correct as there is an "a" but "plugins" is plural. Something like "It can be used as a standalone instrument (JACK client), and also as a LV2 or VST3 plugin."? 5. I see there is a brand new Virtual Package "Provides: vst3-plugin". We have a lv2-plugin virtual package, but vst3-plugin would be new. Has it been discussed on the DMT mailing list? d/copyright: 6. I am not sure the "~dfsg0:" comment explaining why sfizz has been repacked (which is a good thing to do) complies with the machine readable copyright format. It is probably better to put the comment after a "Comment:" stanza. 7. The MIT license text used in d/copyright is not the same as that in the files in the benchmark folder. An MIT/X11 license text with extra conditions has been used instead. 8. clients/jack_client.cpp is not copyrighted to Andrea Zanellato 9. fmidi_mini.cpp under clients/* is copyrighted under the Boost license, which is not the same as the BSD-2-Clause license. I stopped reviewing the copyright file at this point. I would recommend a thorough review, as the ftp-masters will do a similar check and the package would probably be rejected as it stands. d/rules: 10. I noticed the build system has an option to enable the test suite. Is there a reason why this has been skipped? 11. I see that there are manual overrides of various targets adding a manual Cmake command. I believe debhelper (dh) just does the right thing these days & it should only be necesary to override d/rules to append extra build options. Have you tried buiding the package without these overrides? Other comments: 12. It would be good to provide an upstream metadata file. 13. I am afraid the package fails to build twice in a row, which probably means there is a problem with the "clean" target. 14. There are quite a few lintian errors that could be investigated/fixed: W: sfizz: duplicate-font-file usr/lib/lv2/sfizz.lv2/Contents/Resources/Fonts/Roboto-Regular.ttf also in fonts-roboto-unhinted W: sfizz: duplicate-font-file usr/lib/vst3/sfizz.vst3/Contents/Resources/Fonts/Roboto-Regular.ttf also in fonts-roboto-unhinted W: sfizz: link-to-shared-library-in-wrong-package usr/lib/libsfizz.so.0 usr/lib/libsfizz.so W: sfizz: no-manual-page usr/bin/sfizz_jack W: sfizz: no-manual-page usr/bin/sfizz_render W: sfizz: package-name-doesnt-match-sonames libsfizz0 W: sfizz: pkg-config-unavailable-for-cross-compilation usr/lib/pkgconfig/sfizz.pc X: sfizz: exit-in-shared-library usr/lib/libsfizz.so.0 I: sfizz: extra-license-file usr/lib/lv2/sfizz.lv2/LICENSE.md I: sfizz: extra-license-file usr/lib/vst3/sfizz.vst3/gpl-3.0.txt I: sfizz: font-in-non-font-package usr/lib/lv2/sfizz.lv2/Contents/Resources/Fonts/sfizz-fluentui-system-r20.ttf I: sfizz: font-in-non-font-package usr/lib/vst3/sfizz.vst3/Contents/Resources/Fonts/sfizz-fluentui-system-r20.ttf I: sfizz: font-outside-font-dir usr/lib/lv2/sfizz.lv2/Contents/Resources/Fonts/sfizz-fluentui-system-r20.ttf I: sfizz: font-outside-font-dir usr/lib/vst3/sfizz.vst3/Contents/Resources/Fonts/sfizz-fluentui-system-r20.ttf I: sfizz: hardening-no-bindnow usr/bin/sfizz_jack I: sfizz: hardening-no-bindnow usr/bin/sfizz_render I: sfizz: hardening-no-bindnow usr/lib/libsfizz.so.0 I: sfizz: hardening-no-bindnow usr/lib/lv2/sfizz.lv2/Contents/Binary/sfizz.so I: sfizz: hardening-no-bindnow usr/lib/lv2/sfizz.lv2/Contents/Binary/sfizz_ui.so I: sfizz: hardening-no-bindnow usr/lib/vst3/sfizz.vst3/Contents/x86_64-linux/sfizz.so I: sfizz: hardening-no-fortify-functions usr/bin/sfizz_jack I: sfizz: hardening-no-fortify-functions usr/bin/sfizz_render I: sfizz: hardening-no-fortify-functions usr/lib/libsfizz.so.0 I: sfizz: hardening-no-fortify-functions usr/lib/lv2/sfizz.lv2/Contents/Binary/sfizz.so I: sfizz: hardening-no-fortify-functions usr/lib/lv2/sfizz.lv2/Contents/Binary/sfizz_ui.so I: sfizz: hardening-no-fortify-functions usr/lib/vst3/sfizz.vst3/Contents/x86_64-linux/sfizz.so I: sfizz: no-symbols-control-file usr/lib/libsfizz.so.0 I: sfizz: package-contains-documentation-outside-usr-share-doc usr/lib/lv2/sfizz.lv2/LICENSE.md I: sfizz: package-contains-documentation-outside-usr-share-doc usr/lib/vst3/sfizz.vst3/gpl-3.0.txt I: sfizz: spelling-error-in-binary usr/bin/sfizz_jack helpfull helpful P: sfizz source: co-maintained-package-with-no-vcs-fields X: sfizz source: debian-watch-does-not-check-gpg-signature P: sfizz: image-file-in-usr-lib usr/lib/lv2/sfizz.lv2/Contents/Resources/background.png P: sfizz: image-file-in-usr-lib usr/lib/lv2/sfizz.lv2/Contents/Resources/background@2x.png P: sfizz: image-file-in-usr-lib usr/lib/lv2/sfizz.lv2/Contents/Resources/icon_white.png P: sfizz: image-file-in-usr-lib usr/lib/lv2/sfizz.lv2/Contents/Resources/icon_white@2x.png P: sfizz: image-file-in-usr-lib usr/lib/lv2/sfizz.lv2/Contents/Resources/knob48.png P: sfizz: image-file-in-usr-lib usr/lib/lv2/sfizz.lv2/Contents/Resources/knob48@2x.png P: sfizz: image-file-in-usr-lib usr/lib/lv2/sfizz.lv2/Contents/Resources/logo.png P: sfizz: image-file-in-usr-lib usr/lib/lv2/sfizz.lv2/Contents/Resources/logo_text.png P: sfizz: image-file-in-usr-lib usr/lib/lv2/sfizz.lv2/Contents/Resources/logo_text@2x.png P: sfizz: image-file-in-usr-lib usr/lib/lv2/sfizz.lv2/Contents/Resources/logo_text_white.png P: sfizz: image-file-in-usr-lib usr/lib/lv2/sfizz.lv2/Contents/Resources/logo_text_white@2x.png P: sfizz: image-file-in-usr-lib usr/lib/vst3/sfizz.vst3/Contents/Resources/background.png P: sfizz: image-file-in-usr-lib usr/lib/vst3/sfizz.vst3/Contents/Resources/background@2x.png P: sfizz: image-file-in-usr-lib usr/lib/vst3/sfizz.vst3/Contents/Resources/icon_white.png P: sfizz: image-file-in-usr-lib usr/lib/vst3/sfizz.vst3/Contents/Resources/icon_white@2x.png P: sfizz: image-file-in-usr-lib usr/lib/vst3/sfizz.vst3/Contents/Resources/knob48.png P: sfizz: image-file-in-usr-lib usr/lib/vst3/sfizz.vst3/Contents/Resources/knob48@2x.png P: sfizz: image-file-in-usr-lib usr/lib/vst3/sfizz.vst3/Contents/Resources/logo.png P: sfizz: image-file-in-usr-lib usr/lib/vst3/sfizz.vst3/Contents/Resources/logo_text.png P: sfizz: image-file-in-usr-lib usr/lib/vst3/sfizz.vst3/Contents/Resources/logo_text@2x.png P: sfizz: image-file-in-usr-lib usr/lib/vst3/sfizz.vst3/Contents/Resources/logo_text_white.png P: sfizz: image-file-in-usr-lib usr/lib/vst3/sfizz.vst3/Contents/Resources/logo_text_white@2x.png P: sfizz source: package-does-not-install-examples editor/external/vstgui4/vstgui/standalone/examples/ P: sfizz source: silent-on-rules-requiring-root P: sfizz source: source-contains-autogenerated-visual-c++-file vst/external/VST_SDK/VST3_SDK/public.sdk/source/vst/aaxwrapper/resource/aaxwrapper.rc X: sfizz source: upstream-metadata-file-is-missing Let us know on the list if you need any help to improve things. -- Regards, Ross Gammon FBEE 0190 904F 1EA0 BA6A 300E 53FE 7BBD A689 10FC
Attachment:
signature.asc
Description: OpenPGP digital signature