Bug#960831: about RFS: yiyantang
Control: moreinfo -1
On Wed, Sep 30, 2020 at 08:29:29PM +0800, xiao sheng wen wrote:
> Hi, Tobias,
>
> Thanks for your review.
>
> I had uploaded the new package, please help to review again.
>
> 在 2020/9/29 下午10:44, Tobias Frost 写道:
> > So, congrats for becoming de-facto* upstream then… ;-)
> >
> > (* due to maintaining a dead-upstream package)
>
> I'm planning to find the appropriate person to become the new upstream
> in the Chinese open source community.
>
> But this finding need time, perhaps we have lucky.
>
> > Yes, I see*. But I fear that needs to be debugged and eventually
> > be fixed or it will fly right into your face, at some point of time**…
> >
> > At the very least, config.guess and config.sub needs updating
> > frequently. (See /usr/share/doc/autotools-dev/README.Debian.gz)
> Read it.
> > (* The reason for the failure seems to be in configure.in:59; but I did not try
> > anything except commenting out that line; autoreconf suceeds then but configure
> > fails later.)
>
> It's not a easy thing for me that change the code to use autoreconf and
> let the rebuild package success .
>
> I'm not a programmer. :-(
Ehm, well
*some* programming skill ought to be useful when maintaining packages.
Well, ok, you'll learn the skills, I'm sure.
> > d/copyright:
> > - You need to have the complete GPL boiler plate in the License text.
This is still missing.
Also, this is not a license text for GPL-2
This package was debianized by Yu Guanghui <ygh@debian.org> on
Tue, 1 May 2001 22:23:01 +0800.
> > Note, if you license debian/* GPL-2*+* you need to have an extra
> > section for the different license. (GPL-2 != GPL-2+)
> used GPL-2 in this upload.
Well, d/copyright is inconsistent with the source code. Please recheck
and update it. For example:
- Upstream code is GPL-2+, at least setty.c
- Other files have same license, but different copyright holders.
- Please ensure to quote the complete license boiler plate,
(all 3 paragraphs; if necessary, change the FSF address. "*" can
be stripped.)
> > - Please also mention the previous maintainers in the debian/* section.
> I find the previous maintainers info from git log and added to the
> d/copyright file.
--
tobi
Reply to: