[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#960831: about RFS: yiyantang



Control: tags -1 moreinfo

On Sat, Sep 26, 2020 at 11:37:25AM +0800, xiao sheng wen 肖盛文 wrote:
>  Control: tags 960831 - moreinfo
> 
> Hi Tobias Frost,
> 
>  I'm the maintainer of the package yiyantang , so I use NMU to upload
> that is inappropiate before.

OK

> I'd uploaded the new version yiyangtang package on mentors[1], please
> help to review again.
> 
> yiyantang is very old package, It's upstream is not exist now. The watch
> file is bare.
> 
> The watch file like this, Is need to delete ?

If upstream is gone and won't come back you can delete the watch file.
Did you look if there are any forks that could be new upstream?

Here's a review:
- don't mark the bugs as "forwarded: not needed" if upstream is gone.
Either ignore (not override) the lintian thingy, or mark write "forwarded:
no, dead upstream."

"not needed" is kind of reserved for Debian specific patches.

The patch "fix-type-error" should be rather named "fix-typo" (with "o" instead of "e")…
(the current name is confusing…)

Why is the package not using autoreconf? It seems to use autotools…

Cheers,
tobi



 
> Thanks for your mentor.
> 
> 
> [1] https://mentors.debian.net/package/yiyantang/
> 
> -- 
> 肖盛文 xiao sheng wen Faris Xiao 
> 微信(wechat):atzlinux
> 《铜豌豆 Linux》 
> 基于 Debian 的 Linux 中文桌面操作系统:https://www.atzlinux.com
> Debian QA page: https://qa.debian.org/developer.php?login=atzlinux%40sina.com
> GnuPG Public Key: 0x339240CB
> 
> 


Reply to: