[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#965363: RFS: opencpn/5.2.0+dfsg-1 [RC] -- Open Source Chartplotter and Marine GPS Navigation Software



On Wed, Sep 09, 2020 at 10:53:37PM +0200, Alec Leamas wrote:
> Hi,
> 
> A new version is uploaded to mentors. Time to reset the history. Changes
> since last round:
> 
>   - New warning dialog for downloading binary plugin content (patch).
>   - Spelling error fixed
>   - Removed references to upstream bugs. I think it's a pity, the
>     references linked patches in d/patches to upstream bugs.

Well, actually, all those lines probably should be removed: debian/changelog is intended
to record changes to the packaging part only, it is not to record
changes made upstream; more generally: Only stuff that changes files
in the debian directory should be mentioned in d/changelog.
(See https://www.debian.org/doc/debian-policy/ch-source.html#debian-changelog-debian-changelog
for some better/more accurate wording in the Policy)

To link patches to upstream issues, dep3 headers are used in the patches:
https://dep-team.pages.debian.net/deps/dep3/

Quilt can help your here for filling it out:
  quilt header -e --dep3
(for the current applyed patch)

>   - Fixed the d/copyright mess.

+1 (Though I did not review it in depth; but many thanks for taking care about it! )

>   - Left compat level at 12 according to discussion.
> 
> Thoughts?

I will try to take a look this evening after DAYJOB concluded.

But thanks for updating the package so far!

> 
> Cheers!
> --alec
> 


Reply to: