[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#969782: RFS: jag/0.3.8-1 -- arcade and puzzle 2D game



Hi Carlos,

> The test added just does 'jag &' which does not provide significant
> test coverage as is evident from the output.
> 
> autopkgtest [21:14:03]: test command1: jag &
> autopkgtest [21:14:03]: test command1: [-----------------------
> 
> qt.qpa.xcb: could not connect to display 
> qt.qpa.plugin: Could not load the Qt platform plugin "xcb" in "" even though it was
> found.

I think the test is not yet working.

jag is a graphical application, but you are not instructing autopkgtest
to start a (virtual) X server.
And even if this was working, what would this actually be testing?

I think the autopkgtest is only passing because of the & which starts it
in the background (where it fails to start) and then the shell process exits
successfully?

I would recommend to remove the test as it's currently not testing
anything (not even "superficially"). Writing a proper test for a game
is probablby quite difficult, though maybe someone else has a better
idea how this could be tested.

Kind regards,
  Reiner

Attachment: signature.asc
Description: PGP signature


Reply to: