Bug#942884: Bug#971395: RFS: zipios++/2.2.5.0-1 -- small C++ library for reading zip files (documents)
On Mon, Oct 12, 2020 at 06:06:58PM +0200, Tobias Frost wrote:
>
> > > d/rules + d/control:
> > > - It looks like as your rules already supports building docs in
> > > build-indep.
> > > Please see if you can move doxygen / graphviz B-D to Build-Depends-
> > > Indep.
> >
> > Done
>
> I have problems building only the arch:all packages, but I will
> need to investigate first if the problem is on my side.
> (Running out of time right now)
Following up on that one:
No, it was not on my side… It was a combination of limited build system support
for building only the documentation and more targets needs to be overriden in
d/rules for -arch and -indep.
It unearthed also a bug in the override for dh_auto_install-indep: The
generated makefile does not have a doc target…
I sent a MR towards you, which fixes this. The changes for this are:
- include /usr/share/dpkg/architecture.mk to get DEB_HOST_GNU_TYPE
- override override_dh_auto_configure-arch to only enable tests there.
- override_dh_auto_build-indep: use DEB_HOST_GNU_TYPE to enter build dir
and use $(MAKE) zipios_Documentation to create docs. (make docs wont work)
- as make install is not working for docs only builds, override_dh_auto_install-indep
simulating this.
In the same MR, I remove the manpages: I just saw (when debugging above)
that those are doxygen generated manpages and, franky, not very useful.
(on top, they are leaking build paths)
Another small fix:
d/copyright does not needed to be mentioned in libzipios++-doc.install.
Its picked up automatically. (so deleted the file)
d/dirs is not needed, and can be deleted.
I left it up to you to make nice d/changlog entries for those changes…
Afterwards I guess we are ready to upload it.
For subsequent uploads, you might want to take a look at:
usr/share/doc/libzipios-dev/html/classzipios_1_1VirtualSeeker.html,
why it has the buildpath in it. (lintian I-type tag)
(This possibly fixes also the reproducible build issue)
Cheers,
--
tobi
Reply to: