Control: tags -1 moreinfo On Wed, Sep 30, 2020 at 10:43:36PM +0200, François Mazen wrote: > Hello Tobias, > > > # please do not reopen new bugs if the old one was not sponsored. > > # -- otherwise context is lost. > > Sorry for the mess, I thought that I had to open a new sponsorship > request due to different package name. > > > You need to upload it to experimental first. > > Updated package ready to experimental at mentors: > https://mentors.debian.net/package/zipios++/ > > Could you please upload and review? d/control: - I'm seeing that the -dev package is now renamed. That will force you to do sourceful uploads of all the reverse dependencies during the transitions. Additionally, upstream includes changed directory names and lots of other changes that break API… So, yes, sourceful upload of all r-depends it will be… And you likely will need to provide patches. (Luckily, those r-depends are just two: freecad and enigma) TL;DR: its ok… - On the dev package: It should not Conflict/Replaces, It should be Breaks/Replaces. (see policy 7.4; you are moving a file from the old one to the new one.) (disclaimer: I'm 100% sure on that one, happy if someone could chime in) - On the library package: Here I'm pretty sure the conflict will do harm: it will make the transition harder. The binary library packages should be coinstallable with the old one, so there shouldn't be a need for the Conflict/Replace, not even a Breaks/Replaces. (The old one had one due to the c++-abi transition a few years ago, IIRC) (This is also not a package rename situation, as libraries are pulled in by reverse dependencies; and in contrast to renames, you don't want to uninstall the old one automatically: there might be packages (outside of the Debian archives) that still needs it,.) - On the docs package: This is a classic "package renaming" situation explained here: https://wiki.debian.org/RenamingPackages. So you will need a transistional package here as well. Or not renaming the -doc package. d/docs: - don't install README.md -- it does not have important information (mostly how to build, which is not relevant in binary packages) - NEWS should be installed as upstream changelog (see dh_installchangelogs) d/rules + d/control: - It looks like as your rules already supports building docs in build-indep. Please see if you can move doxygen / graphviz B-D to Build-Depends-Indep. (doxygen has a huge dependency list, so it is worth to do that) - The docs package has references to the old package: uilding the docs package shows in the package the following paths, I guess they are not updated: drwxr-xr-x root/root 0 2020-03-07 14:08 ./usr/share/doc/libzipios++-doc/ drwxr-xr-x root/root 0 2020-03-07 14:08 ./usr/share/doc/libzipios++-doc/html/ (...) lrwxrwxrwx root/root 0 2020-03-07 14:08 ./usr/share/doc/libzipios++-doc/html/jquery.js -> ../../../javascript/jquery/jquery.min.js BTW, it is _NOT_ recommended to replace the jsquery from doxygen. read /usr/share/doc/doxygen/README.jquery. If lintian complains, override it. - The dev package has the following files, which shoudln't be there: drwxr-xr-x root/root 0 2020-03-07 14:08 ./usr/share/doc/libzipios-doc/ -rw-r--r-- root/root 1654 2019-08-17 00:13 ./usr/share/doc/libzipios-doc/NEWS.gz -rw-r--r-- root/root 2352 2019-08-17 00:13 ./usr/share/doc/libzipios-doc/README.md.gz - The dev package isntalls the man pages. Shouldn't they go to the -doc package? (probably you just need to mv d/manpages d/libzipios-doc.manpages) - d/rules: What was the problem with "# dh_installdocs does not detect the doc main package correctly."? (Very often dh not working is not a problem with dh, but some packaging issue) Blindly guessing, it might be this: --doc-main-package is usually used to install the documentation to the _main_ binary package, not the main _doc_ package (see dh_installdocs). Policy 12.3 could be read to suggests to install the docs for a shared libary in /usr/share/doc/libzipios-dev (so the -doc package would ship the docs in this directory, but 1) that could be my reading and 2) its optional. This overrides could also be the reason for the spourious files mentioned above (-dev) - There is also dh_doxygen. Maybe this is helpful to avoid needing the overrides above. It should take care about those md5's. - As per Policy 12.3, the -dev package should Suggest: the -doc package. (I ran out of time here, so I can't analyze whats causes the problems above. Sorry for only pointing out the problems without providing pointers/solutions.) -- tobi
Attachment:
signature.asc
Description: PGP signature