Hi Georgy,
(I'll delete the sections which has been handled, to keep the mail
uncluttered)
On Sun, Sep 20, 2020 at 05:35:47PM +0300, Georgy Komarov wrote:
Control: tags -1 moreinfo
# taking care of this sponsorship until uploaded.
Control: owner -1 !
>
> Hello Tobias,
>
> > - d/copyright:
(with Cyrils OK ✔)
> > - The package needs to be adapted for multiarch: It needs to install the
> > shared libaries to /usr/lib/${DEB_HOST_MULTIARCH}/
you should could /usr/lib/${DEB_HOST_MULTIARCH}/ instead
of /usr/lib/*/ in d/install…. This is possible since compat 13)
Ok. Lintian is a bit sad:
I: libwcat1: hardening-no-bindnow usr/lib/x86_64-linux-gnu/libwcat.so.1.1.1
(It seems that LDFLAGS is not passed to the linker)
I: libwcat1: hardening-no-fortify-functions usr/lib/x86_64-linux-gnu/libwcat.so.1.1.1
(possibly a false positive)
I: libwcat1: package-contains-empty-directory usr/include/
(reason: listed in d/libwcat1.install)
I: libwcat1 source: patch-not-forwarded-upstream debian/patches/0001-Makefile-do-not-strip.patch
I: libwcat1 source: patch-not-forwarded-upstream debian/patches/0002-Makefile-add-libdir.patch
(add a Forwarded header, possibly with not-needed or Debian-specific)
I: libwcat1: symbols-file-missing-build-depends-package-field
(see tag description, not evaluted further)
X: libwcat1 source: debian-watch-does-not-check-gpg-signature
(irrelevant, just ignore it)
P: libwcat1 source: insecure-copyright-format-uri http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
(easy to fix.)
P: libwcat1 source: silent-on-rules-requiring-root
(see policy §5.6.31)
So not much left before uploading … Ping me when ready!
>
> > (not a requirement for upload of this package:
> > The library package has also a companion tool package: watchcatd [1].
> > It is also orphaned. Would you mind adopting this too?)
>
> Interesting. I'll take this package after I finish working on this one.
Nice! Thanks for that!
--
Cheers,
tobi
Attachment:
signature.asc
Description: PGP signature