[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#969446: RFS: vguitar-2.6 [ITP] -- Play Guitar in any term window. Use with a MIDI synthesizer (qsynth).



Hi Nick,

在 2020-09-04星期五的 12:51 +0000,Nick Strauss写道:
> Hi Boyuan Yang,
> 
> I have added my source architecture to repo
> 
> 
> apt-key adv --keyserver keyserver.ubuntu.com --recv-keys AB406C34
> add to /etc/apt/sources.list.d
> deb-src http://apt.nick-strauss.com/apt/debian jessie main
> apt-get source vguitar

I have reviewed your source package. The current problem is that
literally every packaging file in debian/ directory comes directly from
the template files and the template information are not removed. This
indicates a lack of manual review after generating those files.

Please review each of those files and make sure that unnecessary
template placeholders are not included in your packaging debian/ dir.
Please pay special attention to the debian/copyright file since it was
obviously the result of some automatic scan and can be greatly
simplified. If you have doubts in packaging, please make sure you
follow the instructions in 
https://www.debian.org/doc/manuals/developers-reference/best-pkging-practices.en.html
 and https://www.debian.org/doc/debian-policy/ch-source.html .

Thanks,
Boyuan Yang


> On Thursday, September 3, 2020, 09:44:37 AM CDT, Boyuan Yang <
> byang@debian.org> wrote: 
> Control: close 969445
> Control: tags -1 +moreinfo
> 
> Hi Nick,
> 
> Thanks for your interest in getting software into Debian. Some
> comments:
> 
> * Since you submitted two duplicated RFS requests, I am closing one
> of
> them to make sure that there are no duplications.
> 
> * I reviewed the package you provided and found that you only
> provided
> the binary package (.deb) for amd64 architecture, which is not
> acceptable at this moment. In order to make the software into Debian,
> you will have to provide the source package (.dsc file and related
> source tarballs) so that Debian can review the source code of such
> software as well as build the binary packages for other officially-
> supported architectures (i386, arm* etc.). Please follow the
> instruction texts in https://mentors.debian.net/intro-maintainers/
> and
> prepare your Debian source package properly.
> 
> Please fix the problems mentioned above and let people know when it's
> ready again by replying your RFS report at 
> https://bugs.debian.org/969446 .
> 


Reply to: