On Thu, 09 Jul 2020 18:42:23 +0300, Boian Bonev wrote: > > It's not enabled by default, but you can add > > export DEB_BUILD_MAINT_OPTIONS = hardening=+bindnow > > to debian/rules to add the flag. > -export LDFLAGS=-Wl,-z,now $(shell dpkg-buildflags --get LDFLAGS) > +export DEB_BUILD_MAINT_OPTIONS=hardening=+bindnow > > Looks much cleaner in this way. Great. > > But I guess in this case a Breaks would be more appropriate than a > > Conflicts. > > Cf. 7.3 and 7.4 in Debian Policy > > https://www.debian.org/doc/debian-policy/ch-relationships.html#packages-which-break-other-packages-breaks > > ff. > I have changed Conflicts to Breaks+Replaces and it seems to work OK. > Because both packages would install the same file, only Breaks wouldn't > do, IMO, correct me if I am worng. Right, if a file is taken over, an additional Replaces is indeed needed; good catch. > > Well, you could write an autopkgtest :) > > Cf. https://ci.debian.net/doc/file.MAINTAINERS.html , > > https://salsa.debian.org/ci-team/autopkgtest/raw/master/doc/README.package-tests.rst > > etc. > > (But IMO that's not required for a first upload.) > Writing a good test is quite far from trvial for this program. I will > need some scartch space to write files to, run couple of processes that > do IO in the scratch area according to some predefined pattern, collect > the data via iotop (needs root) in batch mode and verify if the > collected data matches the expected pattern... I would estimate that as > about 2x the complexity of iotop itself. Ack, I totally see that this is a non-trivial task in this case. Maybe something to keep in the back of your mind for long dark winter nights :) Cheers, gregor -- .''`. https://info.comodo.priv.at -- Debian Developer https://www.debian.org : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06 `. `' Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe `- NP: Cat Stevens: Girl, You'll Be A Woman Soon
Attachment:
signature.asc
Description: Digital Signature