[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#963832: RFS: iotop-c/1.0-1 [ITP] -- iotop-c - simple top-like I/O monitor (implemented in C)



On Sun, Jun 28, 2020 at 05:33:30AM +0300, Boian Bonev wrote:
>  * Package name    : iotop-c
>    Version         : 1.4-1

> Changes since the last upload:
> 
>    * Upstream release 1.4

Hi!
1. What "last upload"?  This is the first release into Debian.  And thus,
there's no history yet -- work in progress that hasn't ever been uploaded
to the archive isn't really of interest to anyone (except maybe a git
archive).  The changelog is meant to notify users and other developers
what has been changed.  Thus, could you please squash this into just
"Initial release: closes #123456"?

The only case when keeping such history would be good is when the package
had already been provided via some other repository, such as a Debian
derivative (such as Ubuntu, Devuan, Mint...) or at least to a group of
users.

2. The package fails to build:
   dh_auto_install
	make -j64 install DESTDIR=/<<PKGBUILDDIR>>/debian/iotop-c AM_UPDATE_INFO_DIR=no "INSTALL=install --strip-program=true"
make[1]: Entering directory '/<<PKGBUILDDIR>>'
STRIP iotop
INSTALL iotop
install: cannot change ownership of '/<<PKGBUILDDIR>>/debian/iotop-c/usr/sbin/iotop': Operation not permitted
make[1]: *** [Makefile:53: install] Error 1
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
dh_auto_install: error: make -j64 install DESTDIR=/<<PKGBUILDDIR>>/debian/iotop-c AM_UPDATE_INFO_DIR=no "INSTALL=install --strip-program=true" returned exit code 2

3. The long desc talks about kernel 2.6.20.  This is no longer relevant, as
Debian won't work on kernels < 3.2 (non-systemd) or < 3.13 (systemd), many
packages probably having a much newer requirement.  Thus, this piece can
be dropped.


Meow!
-- 
⢀⣴⠾⠻⢶⣦⠀
⣾⠁⢠⠒⠀⣿⡁ in the beginning was the boot and root floppies and they were good.
⢿⡄⠘⠷⠚⠋⠀                                       -- <willmore> on #linux-sunxi
⠈⠳⣄⠀⠀⠀⠀


Reply to: