[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#961738: RFS: dragengine/1.1 -- Drag[en]gine Game Engine


(see bottom)

Roland Plüss <roland@rptd.ch> 于2020年5月28日周四 上午10:45写道:
> Package: sponsorship-requests
> Severity: normal
> Dear mentors,
> I am looking for a sponsor for my package "dragengine"
> * Package name : dragengine
> Version : 1.1
> Upstream Author : roland@rptd.ch
> * URL : https://dragondreams.ch
> * License : LGPL-3.0+
> * Vcs : upstream debianization branch:
> https://github.com/LordOfDragons/dragengine/tree/debian
> Section : x11
> It builds those binary packages:
> dragengine - Drag[en]gine Game Engine
> dragengine-dev - Drag[en]gine Game Engine Development
> deigde - Drag[en]gine Game Development Environment
> deigde-dev - Drag[en]gine IGDE Development
> To access further information about this package, please visit the
> following URL:
> https://mentors.debian.net/package/dragengine

Long story short, this hasn't reached a satisfactory quality. I will
point out issues
I found but there are more to fix.

* Please make sure the debian/files file does not exist in your packaging.
This file is automatically created and should not be created manually.

* Your debian/postinst script is missing the #DEBHELPER# placeholder.

* Your debian/postinst file has to recognize whether it is being
called during installation,
upgrade or removal. See
https://www.debian.org/doc/debian-policy/ch-maintainerscripts.html for
I guess the best way is to take a look at existing postinst scripts
written by others.

* Official Debian packages in "main" section should not manipulate
files under /opt/ directory at any time.
Your package will be part of the system, not some so called "Optional
application software packages".
Please place files following the File Hierarchy Standard (FHS) using
directories under /usr/.

* You are using "3.0 (native)" format, which is not suitable for a
non-Debian-specific project.
See https://www.debian.org/doc/manuals/maint-guide/advanced.en.html#native-dh-make
for details. Please use "3.0 (quilt)" format.

* Your "Build-Depends" field is missing way too many build
dependencies. An easy example
is that if scons is not installed on your system, your package surely
cannot build. Please list
all non-trivial build-dependencies required to build your package. See
for details.

* Your package bundles way too many external libraries under /extern/
directories. You must
either document license information for those project or exclude those
files from your source code.
If building your package needs those libraries, please use existing
libraries in current Debian archive.

There are other issues but I'd rather stop here. Since you yourself is
also the upstream,
it could be possible for you to actually review the software
buildsystem (scons scripts) since it seems
to have diverted from traditional software installation procedures on
UNIX-like platforms. In any case,
the source repository and packaging scripts your provided need improvement.

Boyuan Yang

Reply to: