[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#960370: RFS: jag/0.3.7-1 -- arcade and puzzle 2D game

Hi Peter,

> Hmm, I see that you have not uploaded these changes to the Salsa
> repository; it seems to me that you are in the habit of making changes
> somewhere else, then importing them in a single commit once the package
> has been uploaded. I think it might be a bit more useful for
> collaboration to have your work in the Salsa repository, too.
> Not a blocker, just something that caught my eye.

Exactly what I do, after uploading the package to mentors.d.n, I am waiting for
the sponsor to analyze the package and, after everything is right, send it to
the salsa repository.

I don't know if I have permission at this point to make my changes to my package
directly through the salsa repository.

I would like to find a link to do the correct procedure for this.

> The test definition in the debian/tests/control file has a "Depends:"
> line listing both "@" and "jag-data". It is my understanding that "@"
> stands for "all the binary packages built in this run", so "jag-data" is
> not needed there.

I understand, I will remove the "jag-data" in "Depends:". I am still adapting to
add autopkgtest to my packages.

> The test itself seems a bit weird to me, too. It looks like jag is
> a graphical application; I have not tried running the test, but I wonder
> if it might be better to explicitly specify something like a fake X
> server; right now I can't quite recall the name, but I'm pretty sure
> that I've seen some kind of "no real video output, but all the Xlib
> calls and events" server used for testing; it might have been Xvfb.

Sorry, I didn't get it right. Could you help me so I can specify better? :/

> On a related note, I see that in version 0.3.6-1 you removed the "same
> as source:Version" constraint in the jag dependency on jag-data; would
> it not be nice to at least have a ">= ${source:Version}" one so that if
> somebody runs "apt install jag", it pulls in a usable version of
> jag-data automatically?

In version 0.3.6-1, I removed ">= ${source:Version}" because one of the sponsors
told me that I wouldn't need this because "jag-data" is in the same package as
"jag". When I run "apt install jag", it automatically extracts "jag-data"
normally. But I can add again without any problems. :)

> Maybe for a future upload, but since you're using version 4 of the watch
> file format, have you considered using the @PACKAGE@, @ANY_VERSION@, etc
> variables that uscan provides now? Of course, it's up to the maintainer
> (you) whether that's more readable, but personally to me, it is.

What I learned at the moment, I use more to download via uscan from my GitLab
repository, whenever there is a new version of the software, and I type: "uscan
--force-download" and then "uupdate".

If you have another, more recent way, let me know where to find it so I can
improve myself.

Thanks and see you!

⢀⣴⠾⠻⢶⣦⠀ Carlos Donizete Froes [a.k.a coringao]
⣾⠁⢠⠒⠀⣿⡁ Debian Wiki: https://wiki.debian.org/coringao
⢿⡄⠘⠷⠚⠋⠀ GPG: 4096R/B638B780
⠈⠳⣄⠀⠀⠀  2157 630B D441 A775 BEFF  D35F FA63 ADA6 B638 B780

Attachment: signature.asc
Description: This is a digitally signed message part

Reply to: