[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#960370: RFS: jag/0.3.7-1 -- arcade and puzzle 2D game

On Tue, May 12, 2020 at 02:13:16AM -0300, Carlos Donizete Froes wrote:
> Package: sponsorship-requests
> Severity: normal
> Dear mentors,
> I am looking for a sponsor for my package "jag"
>  * Package name    : jag
>    Version         : 0.3.7-1
>    Upstream Author : XlabSoft & Industrial Infosystems
>  * URL             : https://gitlab.com/coringao/jag/wikis
>  * License         : GPL-3+
>  * Vcs             : https://salsa.debian.org/games-team/jag
>    Section         : games

Hmm, I see that you have not uploaded these changes to the Salsa
repository; it seems to me that you are in the habit of making changes
somewhere else, then importing them in a single commit once the package
has been uploaded. I think it might be a bit more useful for
collaboration to have your work in the Salsa repository, too.
Not a blocker, just something that caught my eye.

> It builds those binary packages:
>   jag - arcade and puzzle 2D game
>   jag-data - arcade and puzzle 2D game (data file)
> To access further information about this package, please visit the following URL:
>   https://mentors.debian.net/package/jag
> Alternatively, one can download the package with dget using this command:
>   dget -x https://mentors.debian.net/debian/pool/main/j/jag/jag_0.3.7-1.dsc
> Changes since the last upload:
>    * New upstream release. FTCBFS bug fixed. (Closes: #958672)
>      - Fixed integrated qmake support for pkg-config. (Thanks Helmut Grohne)
>    * Added autopkgtest.

The test definition in the debian/tests/control file has a "Depends:"
line listing both "@" and "jag-data". It is my understanding that "@"
stands for "all the binary packages built in this run", so "jag-data" is
not needed there.

The test itself seems a bit weird to me, too. It looks like jag is
a graphical application; I have not tried running the test, but I wonder
if it might be better to explicitly specify something like a fake X
server; right now I can't quite recall the name, but I'm pretty sure
that I've seen some kind of "no real video output, but all the Xlib
calls and events" server used for testing; it might have been Xvfb.

On a related note, I see that in version 0.3.6-1 you removed the "same
as source:Version" constraint in the jag dependency on jag-data; would
it not be nice to at least have a ">= ${source:Version}" one so that if
somebody runs "apt install jag", it pulls in a usable version of
jag-data automatically?

>    * Added debian/docs.
>    * debian/rules:
>      - export DEB_LDFLAGS_MAINT_APPEND removed.
>      - export QT_SELECT removed.
>    * debian/watch:
>      - Fixed the requested URL in the uscan information.

Maybe for a future upload, but since you're using version 4 of the watch
file format, have you considered using the @PACKAGE@, @ANY_VERSION@, etc
variables that uscan provides now? Of course, it's up to the maintainer
(you) whether that's more readable, but personally to me, it is.


Peter Pentchev  roam@ringlet.net roam@debian.org pp@storpool.com
PGP key:        http://people.FreeBSD.org/~roam/roam.key.asc
Key fingerprint 2EE7 A7A5 17FC 124C F115  C354 651E EFB0 2527 DF13

Attachment: signature.asc
Description: PGP signature

Reply to: