Bug#953547: RFS: libusb3380/0.0.1+git20190125.c83d1e9-1 [ITP] -- USB3380 abstraction layer for libusb: development
Hello, Christoph,
I fixed both issues.
On Tue, 2020-03-10 at 17:44 +0100, Christoph Berg wrote:
> Hi Sepi,
>
> there's a missing copyright attribution:
>
> ./cmake_modules/Findlibusb-1.0.cmake:
> # Adapted from cmake-modules Google Code project
> #
> # Copyright (c) 2006 Andreas Schneider
> #
> # (Changes for libusb) Copyright (c) 2008 Kyle Machulis
> #
> # Redistribution and use is allowed according to the terms of the New
> BSD license.
> #
> # CMake-Modules Project New BSD License
> #
> # Redistribution and use in source and binary forms, with or without
> # modification, are permitted provided that the following conditions
> are met:
> #
> # * Redistributions of source code must retain the above copyright
> notice, this
> # list of conditions and the following disclaimer.
> #
> # * Redistributions in binary form must reproduce the above copyright
> notice,
> # this list of conditions and the following disclaimer in the
> # documentation and/or other materials provided with the
> distribution.
> #
> # * Neither the name of the CMake-Modules Project nor the names of
> its
> # contributors may be used to endorse or promote products derived
> from this
> # software without specific prior written permission.
> #
> # THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
> "AS IS" AND
> # ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
> THE IMPLIED
> # WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
> ARE
> # DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS
> BE LIABLE FOR
> # ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
> CONSEQUENTIAL DAMAGES
> # (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
> SERVICES;
> # LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
> CAUSED AND ON
>
> This looks like the lib should be linked with pthreads:
>
> dpkg-shlibdeps: warning: symbol pthread_setname_np used by
> debian/libusb3380-0/usr/lib/x86_64-linux-gnu/libusb3380.so.0.0.1
> found in none of the libraries
> dpkg-shlibdeps: warning: symbol sem_destroy used by
> debian/libusb3380-0/usr/lib/x86_64-linux-gnu/libusb3380.so.0.0.1
> found in none of the libraries
> dpkg-shlibdeps: warning: symbol sem_post used by debian/libusb3380-
> 0/usr/lib/x86_64-linux-gnu/libusb3380.so.0.0.1 found in none of the
> libraries
> dpkg-shlibdeps: warning: symbol pthread_join used by
> debian/libusb3380-0/usr/lib/x86_64-linux-gnu/libusb3380.so.0.0.1
> found in none of the libraries
> dpkg-shlibdeps: warning: symbol pthread_sigmask used by
> debian/libusb3380-0/usr/lib/x86_64-linux-gnu/libusb3380.so.0.0.1
> found in none of the libraries
> dpkg-shlibdeps: warning: symbol pthread_create used by
> debian/libusb3380-0/usr/lib/x86_64-linux-gnu/libusb3380.so.0.0.1
> found in none of the libraries
> dpkg-shlibdeps: warning: symbol sem_init used by debian/libusb3380-
> 0/usr/lib/x86_64-linux-gnu/libusb3380.so.0.0.1 found in none of the
> libraries
> dpkg-shlibdeps: warning: symbol sem_wait used by debian/libusb3380-
> 0/usr/lib/x86_64-linux-gnu/libusb3380.so.0.0.1 found in none of the
> libraries
>
> /usr/lib/x86_64-linux-gnu/libpthread.so:0000000000011370 T sem_close
> /usr/lib/x86_64-linux-gnu/libpthread.so:0000000000010b60 T
> sem_destroy@@GLIBC_2.2.5
> /usr/lib/x86_64-linux-gnu/libpthread.so:00000000000115a0 T
> sem_getvalue@@GLIBC_2.2.5
> /usr/lib/x86_64-linux-gnu/libpthread.so:0000000000010b20 T
> sem_init@@GLIBC_2.2.5
> /usr/lib/x86_64-linux-gnu/libpthread.so:0000000000010e60 T sem_open
> /usr/lib/x86_64-linux-gnu/libpthread.so:00000000000119c0 T
> sem_post@@GLIBC_2.2.5
> /usr/lib/x86_64-linux-gnu/libpthread.so:0000000000011950 T
> sem_timedwait
> /usr/lib/x86_64-linux-gnu/libpthread.so:0000000000011780 T
> sem_trywait@@GLIBC_2.2.5
> /usr/lib/x86_64-linux-gnu/libpthread.so:0000000000011470 T sem_unlink
> /usr/lib/x86_64-linux-gnu/libpthread.so:0000000000011740 T
> sem_wait@@GLIBC_2.2.5
>
> (Not sure this is the correct solution, though.)
>
> The rest is fine and good to go I think.
>
> Christoph
>
Reply to: