Bug#953292: RFS: c-icap/1:0.5.6-1 [QA] -- ICAP server implementation

[Håvard Flaget Aasen <haavard_aasen@yahoo.no>]

Hi,
Thanks for the review!

On 08.03.2020 01:00, Adam Borowski wrote:
> On Sat, Mar 07, 2020 at 10:26:05AM +0100, Håvard Flaget Aasen wrote:
> >   * Package name    : c-icap
> >     Version         : 1:0.5.6-1
>
> > Changes since the last upload:
> >
> >     * QA upload.
> >     * New upstream version 0.5.6
> >     * Update Standards-Version to 4.5.0
> >     * Change to debhelper-compat
> >     * Bump debhelper to 12
> >     * Move Pre-depends field from libicapapi5 to c-icap in d/control
> >     * Fix tab character in d/copyright
> >     * Change path from /var/run/ to /run/ in postinst and postrm scripts
> >     * Update d/libicapapi5.symbols
> >     * autopkgtest, add sleep after restart of service
>
> Hi!
> I don't understand the /var/run/ -> /run/ change -- it looks grossly
> incomplete.  You change it only for the newly created user, but:

The change was done because lintian gave me a warning about it, though 
it probably was a bad call to go trough with it since, as you pointed 
out, the rest of the code refers to /var/run

> * systems which ever had a previous version of c-icap will have the
>    user's home in /var/run/c-icap
> * postrm will remove only the new location (on most systems /var/run/ is a
>    symlink to /run/, though)

I didn't think of this, but shouldn't piuparts notice if files remained 
in the system?

> * the program keeps referring to /var/run/
> * so does its init script
> * and tests
>
>
> Meow!


I have made a new upload without the change from /var/run/ to /run/

Håvard