[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#953292: RFS: c-icap/1:0.5.6-1 [QA] -- ICAP server implementation



On Sat, Mar 07, 2020 at 10:26:05AM +0100, Håvard Flaget Aasen wrote:
>  * Package name    : c-icap
>    Version         : 1:0.5.6-1

> Changes since the last upload:
> 
>    * QA upload.
>    * New upstream version 0.5.6
>    * Update Standards-Version to 4.5.0
>    * Change to debhelper-compat
>    * Bump debhelper to 12
>    * Move Pre-depends field from libicapapi5 to c-icap in d/control
>    * Fix tab character in d/copyright
>    * Change path from /var/run/ to /run/ in postinst and postrm scripts
>    * Update d/libicapapi5.symbols
>    * autopkgtest, add sleep after restart of service

Hi!
I don't understand the /var/run/ -> /run/ change -- it looks grossly
incomplete.  You change it only for the newly created user, but:
* systems which ever had a previous version of c-icap will have the
  user's home in /var/run/c-icap
* postrm will remove only the new location (on most systems /var/run/ is a
  symlink to /run/, though)
* the program keeps referring to /var/run/
* so does its init script
* and tests


Meow!
-- 
⢀⣴⠾⠻⢶⣦⠀
⣾⠁⢠⠒⠀⣿⡁ in the beginning was the boot and root floppies and they were good.
⢿⡄⠘⠷⠚⠋⠀                                       -- <willmore> on #linux-sunxi
⠈⠳⣄⠀⠀⠀⠀


Reply to: