[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#948260: RFS: golang-github-russellhaering-gosaml2/0.3.1-1 [ITP] -- Pure Go implementation of SAML 2.0 (library)



Thanks for the review!

On Wed, Jan 8, 2020 at 12:24 AM Dmitry Smirnov <onlyjob@debian.org> wrote:

> I gave you "developer" access to the team repository. Could you please try to
> push there?

Great, I pushed successfully. I omitted the release tag/commit b007372
(UNRELEASED->unstable) in case further packaging changes are needed.

I think the default branch for some reason is set to 'upstream' rather
than 'debian/sid', would it be possible to change that? Gitlab says I
don't have the right permissions:
https://salsa.debian.org/go-team/packages/golang-github-russellhaering-gosaml2/-/settings/repository

> Everything looks good but it would be great if you could add comment (to
> "copyright" file) regarding source of information about upstream copyright as
> I could not find copyright statement anywhere.

Did you see there is a LICENSE file in the root of the upstream Github
repository? For projects whose only website is a Github repo with a LICENSE
file, is it necessary to add this a comment like this to d/copyright?

Christian


Reply to: