[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#942250: RFS: inkscape-ext-textext/0.12~git32+febf8f7-1 [ITP] -- Re-editable LaTeX graphics for Inkscape



On 10/15/19 12:09 PM, Mattia Rizzolo wrote:
> [ note: not taking ownership of this bug, as I'm not willing to sponsor
> this ITP due to my own policy; also don't explicitly expect an asnwer
> from me to any follow up, I was just curious so I took a little peek ]
> 
> Hi,
> 
> since you used mentors.d.n to keep your package, please consider using
> the template it provides to send the RFS, so it is nicely formatted.
> 

Thanks for taking a look. I'm still getting the hang of this.

> On Sat, Oct 12, 2019 at 08:53:18PM -0600, Antonio Russo wrote:
>> There are a couple outstanding issues, most importantly I don't understand
>> how Inkscape is getting dh_python3 to py3compile its extensions (and not
>> mine). I'd appreciate any help on that end, too.
> 
> Sure.
> 
> First though, let me mention a bunch of other issues.
> 
>> [5] https://salsa.debian.org/aerusso-guest/textext/
> 
> I recommend you look up gbp for handling the git repository for a debian
> package.  Despite having something of a learning curve, once you get the
> hang of the basis it will greatly help you managing your package.  Also,
> there is a growing number of DDs that are more than happy to sponsor
> from such a formatted git repository, than a .dsc.

Yeah, I looked at this before, and opted not to (because I didn't want to
have to learn yet another completely new thing). But if there is strong
momentum for it, I'll move things over to it.

> 
> Also, you CCed the debian-multimedia team, if you wish to maintain this
> in the team, you may want to look up on how to join them, so you can
> also place the repository in the team space.

I was hoping to attract broader attention, and it seems like a reasonable
home for an extension to Inkscape. If there's interest from this team, I am
interested in joining.

> 
>> [3] https://mentors.debian.net/package/inkscape-ext-textext
> 
> This page also already shows a few issues:
> 
>  1. don't close the RFS bug in your upload, that's closed by the
>     sponsor, or automatically by a script after the upload

Ok, that wasn't clear to me. Thank you.

>  2. there is an upstream signature key, but that doesn't really help
>     with tarballs created by you from a git repository.  You can't
>     really provide a signature for those…

Upstream has the key---but I don't remember finding any signed packages.
I'm only packaging from upstream because this is a development branch.

Presumably, the stable release will be sufficient, and I'll just use that
once it is released.

> 
>> [4] dget -x https://mentors.debian.net/debian/pool/main/i/inkscape-ext-textext/inkscape-ext-textext_0.12.0~git32-gfebf8f7-1.dsc
> 
> It looks like there is some odd method to build that package, mhh.
> 

I git archive the repository, and use the hash (and I'm presuming the
next release will be 0.12). Is there a standard way to package upstream
development snapshots?  This is roughly based on what the clementine
packaging does.

> 
> So, the problem with the python3 dependency, is that the files are
> installed in a non-standard directory.  Now, it totally numbs my mind
> why inkscape produces the correct dependency without specifying it (and
> that's even when I am the inkscape maintainer -.-; perhaps it's not
> corect after all, I'll check), but in your case, this does the trick:
> 
> |--- inkscape-ext-textext-0.12~git32+febf8f7/debian/rules        2019-10-13 07:54:29.000000000 +0200
> |+++ inkscape-ext-textext-0.12~git32+febf8f7/debian/rules        2019-10-15 20:03:16.000000000 +0200
> |@@ -27,4 +27,4 @@
> |        dh_installdocs
> |
> | override_dh_python3:
> |-       dh_python3 -p inkscape-ext-textext
> |+       dh_python3 -p inkscape-ext-textext /usr/share/inkscape/extensions/textext/
> 

Thank you. I appreciate this.

> 
> debdiff'ing the .deb:
> |Files in second .deb but not in first
> |-------------------------------------
> |-rwxr-xr-x  root/root   /usr/share/python3/runtime.d/inkscape-ext-textext.rtupdate
> |-rwxr-xr-x  root/root   DEBIAN/postinst
> |-rwxr-xr-x  root/root   DEBIAN/prerm
> |
> |Control files: lines which differ (wdiff format)
> |------------------------------------------------
> |Depends: inkscape (>= 1.0~), pdf2svg | ghostscript, pdf2svg | pstoedit (>= 3.74), python3 (>= 3.7), python3-gi | python3-tkinter, python3-gi-cairo | python3-tkinter, [-texlive-base-] {+texlive-base, python3:any+}
> |Installed-Size: [-206-] {+211+}
> 
> You can see it added a python3:any dependency.  If you were also
> expecting the various modules, then you misunderstood dh_python3: for
> that you need to provide a requires.txt file (or specify the eggs names
> in d/rules, then it would fill them in ${python3:Depends}, see the
> diffoscope package for one that does that).
> 

I don't need the dependencies automatically added--in fact, upstream doesn't ship a requirements.txt,
and I actually think it may be too complex to be expressed in that format.

Best,
Antonio Russo


Reply to: