[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#942250: RFS: inkscape-ext-textext/0.12~git32+febf8f7-1 [ITP] -- Re-editable LaTeX graphics for Inkscape



[ note: not taking ownership of this bug, as I'm not willing to sponsor
this ITP due to my own policy; also don't explicitly expect an asnwer
from me to any follow up, I was just curious so I took a little peek ]

Hi,

since you used mentors.d.n to keep your package, please consider using
the template it provides to send the RFS, so it is nicely formatted.

On Sat, Oct 12, 2019 at 08:53:18PM -0600, Antonio Russo wrote:
> There are a couple outstanding issues, most importantly I don't understand
> how Inkscape is getting dh_python3 to py3compile its extensions (and not
> mine). I'd appreciate any help on that end, too.

Sure.

First though, let me mention a bunch of other issues.

> [5] https://salsa.debian.org/aerusso-guest/textext/

I recommend you look up gbp for handling the git repository for a debian
package.  Despite having something of a learning curve, once you get the
hang of the basis it will greatly help you managing your package.  Also,
there is a growing number of DDs that are more than happy to sponsor
from such a formatted git repository, than a .dsc.

Also, you CCed the debian-multimedia team, if you wish to maintain this
in the team, you may want to look up on how to join them, so you can
also place the repository in the team space.

> [3] https://mentors.debian.net/package/inkscape-ext-textext

This page also already shows a few issues:

 1. don't close the RFS bug in your upload, that's closed by the
    sponsor, or automatically by a script after the upload
 2. there is an upstream signature key, but that doesn't really help
    with tarballs created by you from a git repository.  You can't
    really provide a signature for those…

> [4] dget -x https://mentors.debian.net/debian/pool/main/i/inkscape-ext-textext/inkscape-ext-textext_0.12.0~git32-gfebf8f7-1.dsc

It looks like there is some odd method to build that package, mhh.


So, the problem with the python3 dependency, is that the files are
installed in a non-standard directory.  Now, it totally numbs my mind
why inkscape produces the correct dependency without specifying it (and
that's even when I am the inkscape maintainer -.-; perhaps it's not
corect after all, I'll check), but in your case, this does the trick:

|--- inkscape-ext-textext-0.12~git32+febf8f7/debian/rules        2019-10-13 07:54:29.000000000 +0200
|+++ inkscape-ext-textext-0.12~git32+febf8f7/debian/rules        2019-10-15 20:03:16.000000000 +0200
|@@ -27,4 +27,4 @@
|        dh_installdocs
|
| override_dh_python3:
|-       dh_python3 -p inkscape-ext-textext
|+       dh_python3 -p inkscape-ext-textext /usr/share/inkscape/extensions/textext/


debdiff'ing the .deb:
|Files in second .deb but not in first
|-------------------------------------
|-rwxr-xr-x  root/root   /usr/share/python3/runtime.d/inkscape-ext-textext.rtupdate
|-rwxr-xr-x  root/root   DEBIAN/postinst
|-rwxr-xr-x  root/root   DEBIAN/prerm
|
|Control files: lines which differ (wdiff format)
|------------------------------------------------
|Depends: inkscape (>= 1.0~), pdf2svg | ghostscript, pdf2svg | pstoedit (>= 3.74), python3 (>= 3.7), python3-gi | python3-tkinter, python3-gi-cairo | python3-tkinter, [-texlive-base-] {+texlive-base, python3:any+}
|Installed-Size: [-206-] {+211+}

You can see it added a python3:any dependency.  If you were also
expecting the various modules, then you misunderstood dh_python3: for
that you need to provide a requires.txt file (or specify the eggs names
in d/rules, then it would fill them in ${python3:Depends}, see the
diffoscope package for one that does that).

-- 
regards,
                        Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540      .''`.
More about me:  https://mapreri.org                             : :'  :
Launchpad user: https://launchpad.net/~mapreri                  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-

Attachment: signature.asc
Description: PGP signature


Reply to: