Hi Philipp, thanks for fixing the package. Please find my comments below. On 2019-02-28 15:35, Philipp Meisberger wrote: > thanks for your remarks, especially "pybuild". Really simple now. Sure, > removing files from "/usr/local/" was a fix for an ancient previous > version. I removed it. I also tried to fix all Lintian warnings. Great! It seems much cleaner now. > I am > not very familiar with all RFID protocols. So I cannot say EM4100 is > popular or not. I agree, that "python-em4100" would be a better package > name, but I maintain the project since 2014. So if the name changes > there must be at least the virtual package "python-rfid". Understood. Please notice that as "python-rfid" is not in Debian yet, there is no need for virtual packages there. Nevertheless I agree that it's better to have package's name as close to the upstream's name as possible. > I also heard, that Python 2 will be superseded completely by Python 3 > this year. What is your opinion about the Python 2 package? Is it still > necessary? It's true that Python 2 is going away soon. I suggest dropping Python 2 package it in favor for Python 3. Some additional remarks: 1. Please separate the packaging of your project (the src/debian/ directory) and place it in a packaging repository on salsa.debian.org. This is the usual practice now. 2. I see that the debhelper compatibility level and Standards-Version are outdated. Can you bump them to 12 and 4.3.0, accordingly? 3. Your package build-depends on python3. It isn't necessary, as dh-python brings it with itself. 4. Please add ITP bug number to your debian/changelog. 5. Is doc/RDM6300_doc.pdf your own creation, or taken from somewhere else? In the latter case, please take into consideration possible licensing restrictions on its usage. Let me know should you need any help. Andrius -- Andrius Merkys Vilnius University Institute of Biotechnology, Saulėtekio al. 7, room V325 LT-10257 Vilnius, Lithuania
Attachment:
signature.asc
Description: OpenPGP digital signature