[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#896186: RFS: netctl/1.16-1 [ITP]



2018-05-20 19:50 GMT+08:00 Lumin <cdluminate@gmail.com>:
> control: tag -1 +moreinfo
>
> On Fri, May 04, 2018 at 10:37:27AM +0800, Yangfl wrote:
>> control: tag -1 - moreinfo
>>
>> Reuploaded.
>
> Please fix your packaging repo first:
>
>   https://salsa.debian.org/chinese-team/netctl/network/master
>
> The stuff in the master branch is identical to the upstream branch.
> "debian" directory is contained in no branch. This is an error.
> "upstream" version keeps a copy of untouched upstream source.
> "master" branch is typically holding the debian/ folder on the top
> of the "upstream" branch.
>
> You should fix the packaging repo, or I won't know what on earth
> the changes are.
>
> After fixing the packaging repo, please fix the problematic
> installation path:
>
>   -rw-r--r-- root/root       353 2018-04-20 10:54 ./netctl-ifplugd@.service
>   -rw-r--r-- root/root       284 2018-04-20 10:54 ./netctl-sleep.service
>   -rw-r--r-- root/root       289 2018-04-20 10:54 ./netctl-wait-online.service
>   -rw-r--r-- root/root       260 2018-04-20 10:54 ./netctl.service
>   -rw-r--r-- root/root       316 2018-04-20 10:54 ./netctl@.service
>   drwxr-xr-x root/root         0 2018-04-20 10:54 ./usr/
>
> Run "debc" for a quick content check after building an package.
> Run "lintian -EviI --pedantic" and fix those lintian Warnings.
>
> Please don't remove the moreinfo tag if you are not sure your
> package is totally correct.
>
> Thank you for the update, and please ping me when you are ready
> for the next round of review.

Done.


Reply to: