Bug#916905: RFS: Jerry (Chess GUI) /3.1-0 -- looking for sponsor
Dear Adam,
thanks very much for your feedback.
I've filed an ITP under #917027.
Moreover I've
- changed the icon to a png, since the problem is likely that not all
window manager are able to display .ico
- changed changelog to mark for unstable
- added regexp to track new releases via the watch-file
- modified the copyright file to clarify for all files who owns the
copyright and which license
- The .bin is polyglot opening book. It's format is openly documented,
e.g. here http://hardy.uhasselt.be/Toga/book_format.html
I also changed the changelog
https://github.com/asdfjkl/jerry/releases/tag/v3.1.0 to automatically
close #917027, i.e. if feedback for the ITP is positive and a sponsor
would come forward, the current package might be suitable for inclusion...
kind regards
- Dominik
Am 20.12.2018 um 18:16 schrieb Adam Borowski:
> On Thu, Dec 20, 2018 at 08:33:16AM +0000, Dominik Klein wrote:
>> * Package name : jerry
>> Version : 3.1-0
>> Upstream Author : Dominik Klein / Dominik.Klein@outlook.com
>> * URL : https://github.com/asdfjkl/jerry
>
>> It builds those binary packages:
>>
>> Jerry - a chess program / GUI
>
>> https://github.com/asdfjkl/jerry/releases/tag/v31
>
> Hi!
> Functionally, the program works nearly fine: only nit I noticed is runtime
> icon missing.
>
> You'd need to file an ITP bug, wait a bit for potential responses, and close
> it via the changelog, Also, changelog for packages you request an upload
> for should be marked for unstable rather than UNRELEASED -- that's a marking
> meant to block packages in a state not yet meant to be uploaded.
>
> The watch file should point at a wildcard that will match future releases;
> you have a static URL for the current tarball.
>
> The copyright file needs work:
> * the vast majority of program sources include Karl Josef Klein
> * images have external authors
> * the "book"
>
> The latter also appears to lack any sources. How does one build/edit it?
> It's in some ".bin" format that appears to be a binary blob -- that would
> be bad except that the code refers to it as "Polyglot". How does one deal
> with such Polyglot files?
>
> You don't need to list binary files in debian/source/include-binaries;
> that's only for stuff that's changed during the packaging. Anything within
> the upstream tarball is fine -- .jpg images are also binary, for example.
>
>
> Meow!
>
Reply to: