[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#916905: RFS: Jerry (Chess GUI) /3.1-0 -- looking for sponsor



On Thu, Dec 20, 2018 at 08:33:16AM +0000, Dominik Klein wrote:
> * Package name    : jerry
>    Version         : 3.1-0
>    Upstream Author : Dominik Klein / Dominik.Klein@outlook.com
> * URL             : https://github.com/asdfjkl/jerry

> It builds those binary packages:
> 
>    Jerry - a chess program / GUI

> https://github.com/asdfjkl/jerry/releases/tag/v31

Hi!
Functionally, the program works nearly fine: only nit I noticed is runtime
icon missing.

You'd need to file an ITP bug, wait a bit for potential responses, and close
it via the changelog,  Also, changelog for packages you request an upload
for should be marked for unstable rather than UNRELEASED -- that's a marking
meant to block packages in a state not yet meant to be uploaded.

The watch file should point at a wildcard that will match future releases;
you have a static URL for the current tarball.

The copyright file needs work:
* the vast majority of program sources include Karl Josef Klein
* images have external authors
* the "book"

The latter also appears to lack any sources.  How does one build/edit it?
It's in some ".bin" format that appears to be a binary blob -- that would
be bad except that the code refers to it as "Polyglot".  How does one deal
with such Polyglot files?

You don't need to list binary files in debian/source/include-binaries;
that's only for stuff that's changed during the packaging.  Anything within
the upstream tarball is fine -- .jpg images are also binary, for example.


Meow!
-- 
⢀⣴⠾⠻⢶⣦⠀ 
⣾⠁⢠⠒⠀⣿⡁ Ivan was a worldly man: born in St. Petersburg, raised in
⢿⡄⠘⠷⠚⠋⠀ Petrograd, lived most of his life in Leningrad, then returned
⠈⠳⣄⠀⠀⠀⠀ to the city of his birth to die.


Reply to: