[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#912201: RFS: manticore/2.7.3 [ITP]



Uploaded a new version.
You run `lintian -EvIL +pedantic', don't you? Missing `debian/watch'
considered low-severity issue
Didn't knew about these switches, I'll use that from now on.  

 * no manpage for wordbreaker. You will not pass NEW without it.
 * whitespace errors in debian/rules, debian/copyright, ...
 * missing years in some entries in debian/copyright
done 
 * your documentation should be in /usr/share/doc/manticore, not MANTICORE
removed that folder (not sure why cmake was using uppercased name)
 * I believe you install not all available documentation. You may want
   to create bin:manticore-doc for it.
We don't have a text version of the documentation and it's pretty large. Not sure how would make sense to include it in package when it's online.
 * I doubt usefullness for end-user of internal-coding-standard.txt
Took out 
  * chown manticore:manticore /etc/sphinxsearch is strage. Files in /etc
   are not meant to be edited by someone, but root. Ideally, you should
   assume /etc is mounted read-only.
 * What are relations with bin:sphinxsearch? Are they co-installable?
About these ... there's a big omission I've made: manticore is a replacement for sphinxsearch 
(mantictore is a fork from last OSS version of sphinx, the current sphinxsearch is some kind of free binary only ).
I added Replace and  Break in control file.
The reason /etc/sphinxsearch is chowned in case user switch to manticore (we use different folders for log and data, but kept same config file path). 
 
I will stop here for now. I am sorry to see you use analytics. Your
right as upstream, sure, but it must not appear in html files, provided
by debian.
Which file(s)? none of the files in deb package should have that. Several .md files have that indeed.
If this is a problem (source files), let me know ... I'll see what I can do.

One question about debian/watch: when checking, is the orig.tar.gz uploaded on mentors used or the version from watch? 
Because right now the upstream release doesn't include many of the fixes (they will be all on next one)

Reply to: