Bug#912201: RFS: manticore/2.7.3 [ITP]
> Added a debian/watch, not sure why mentor lintian doesn't see it, uscan
> doesn't report any error, it should get our official tar.gz release for
> github.
You run `lintian -EvIL +pedantic', don't you? Missing `debian/watch'
considered low-severity issue
> Fixed the overrides and indentation.
Nice. It builds. I found at least following issues.
* no manpage for wordbreaker. You will not pass NEW without it.
* whitespace errors in debian/rules, debian/copyright, ...
* missing years in some entries in debian/copyright
* your documentation should be in /usr/share/doc/manticore, not MANTICORE
* I believe you install not all available documentation. You may want
to create bin:manticore-doc for it.
* I doubt usefullness for end-user of internal-coding-standard.txt
* lists in descriptions in `debian/control' are usually indented
by one space
* `manticore' system user seems to not get removed on package purge
* What is the point of 'foo || exit $?' construct with `set -e' set?
* chown manticore:manticore /etc/sphinxsearch is strage. Files in /etc
are not meant to be edited by someone, but root. Ideally, you should
assume /etc is mounted read-only.
* What are relations with bin:sphinxsearch? Are they co-installable?
I will stop here for now. I am sorry to see you use analytics. Your
right as upstream, sure, but it must not appear in html files, provided
by debian.
Also, I remind you that new packages have only one changelog entry, with
revision -1 and single line "Initial release (Closes: #ITP-number)"
Reply to: