I can't seem to ever remember to reply to the BTS, so here's the message forwarded. ----- Forwarded message from Piper McCorkle <zebmccorkle@asymptote.club> ----- Date: Mon, 29 Oct 2018 21:32:15 +0000 From: Piper McCorkle <zebmccorkle@asymptote.club> To: Dmitry Bogatov <KAction@debian.org> Subject: Re: Bug#902324: RFS: zeyple/1.2.2-3 [ITP] Message-ID: <20181029213215.GA5583@asymptote.club> References: <1783205.UGH6EXJrsk@broensted-debian> <1783205.UGH6EXJrsk@broensted-debian> <[🔎] E1gFr8w-0007K8-Ae@eggs.gnu.org> <1783205.UGH6EXJrsk@broensted-debian> <[🔎] 20181027201236.GB8273@asymptote.club> <[🔎] E1gHDkS-0005wo-KI@eggs.gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="vtzGhvizbBRQ85DL" Content-Disposition: inline In-Reply-To: <[🔎] E1gHDkS-0005wo-KI@eggs.gnu.org> User-Agent: Mutt/1.9.4 (2018-02-28) On Mon, Oct 29, 2018 at 08:04:19PM +0000, Dmitry Bogatov wrote: > > // removed items that I have no comments on. > [2018-10-27 20:12] Piper McCorkle <zebmccorkle@asymptote.club> > > > * Build-depend on debhelper >= 11~ (mind the tilde). Be nice to > > > backporters. > > Just recently discovered, that debhelper introduced new syntax for > compat: Build-Depends: debhelper-compat (= 11), and `debian/compat' > is no longer used. Not significant, just FYI. See debhelper(7). Changed. > > > * There seems to be typos in zeyple.1 > > I can't seem to find any typos, could you give an example? > > Sure. > > * In BUGS section, https:// part of URL to upstream bugtracker seems > ito be missing. Fixed. > * In FILES section, `/etc/foo.conf' is referenced. I believe it have > to be `/etc/zeyple.conf' Fixed. > * DESCRIPTION section is rather non-informative. Maybe you could use > something from README on github? Reworded the first sentence and bullet points; fixed. > * According to `zeyple/zeyple.py:278', SYNOPSIS should a least mention > > zeyplin [recepient ...] Fixed. > There is also following issues, I did not noticed last time > {or they did not exist} > > * Your identities in debian/control and debian/changelog differs. > Debian tools compare not only emails, but full name too. Fixed; changed all of them to what I have on a signed PGP UID. > * You build-depends on dh-exec, but seems to not actually use it. Fixed. > * You package does not build twice, since `dh_clean' does not > clean __pycache__ after previous build. Consider something like > > override_dh_auto_clean: > dh_auto_clean > rm -r tests/__pycache__ zeyple/__pycache__ > > debhelper automatically manages this for packages, that use > setuputils. Probably worth discussing with upstream? Added that to d/rules, this is the consensus of upstream wrt setuptools (I assume you meant setuptools instead of setuputils): https://github.com/infertux/zeyple/issues/3 > * It seems that zeyple is new package. So it must have revision -1 > and you have to remove all entries for next revisions. Revision > reflects changes between versions, uploaded into Archives. Fixed. > * Urgency of new packages is always low (`debian/changelog':23) Fixed. > All above apply to commit b6c366. Thanks for all the help with this! -- Piper McCorkle (transitioning s/Zeb(ulon)?/Piper/) zebmccorkle@asymptote.club | https://keybase.io/zebMcCorkle 803A 0F47 82AD DDEA 46BE 055F F8F9 DB8C 1A54 6398 | | __/ __ Asymptote Club / (bad ASCII graph by yours truly) | | ----- End forwarded message -----
Attachment:
signature.asc
Description: PGP signature