Bug#902324: RFS: zeyple/1.2.2-3 [ITP]
control: owner -1 KAction@debian.org
[2018-06-24 20:54] Zebulon McCorkle <zebmccorkle@zeb.fun>
> part 1 text/plain 1032
> Package: sponsorship-requests
> Severity: wishlist
>
> Dear mentors,
>
> I am looking for a sponsor for my package "zeyple"
> zeyple - Automatically encrypt outgoing emails
I like idea of this package, so below is my review; mind you I do not
host any Postfix servers, so I did not checked that it actually works.
* Standards-Version: 4.2.1
* cp zeyple/zeyple.py zeyple/zeyple fails on second invocation of
dpkg-buildpackage. Either (in decreasing order of preference)
+ use dh-exec, which allow you to install and rename
+ add file into 'debian/clean'
+ use 'cp -f'
* Build-depend on debhelper >= 11~ (mind the tilde). Be nice to
backporters.
* Seems that source is written to be compatible with both python3 and
python2. If it true, use python3 dependencies.
* In postinst you create user, but never removes it. Please fix it.
Consider using dh-sysuser, which tries to automate bookkeeping of
system users.
* You seems to run upstream tests as autopkgtest. Any chance to run it
at build time?
* There seems to be typos in zeyple.1
* Maybe it is just my ignorance, but I do not understand reason for the
patch. Mind to write dep-3 description?
Reply to: