Bug#910913: RFS: ghostwriter/1.7.3-1 [ITP]
On 10/13/18 7:56 PM, ghost wrote:
Thanks for reviewing!
I am neither the upstream nor the person who originally uploaded to mentors.d.n,
though I am doing the most fixing part for the package for it to get into Debian...
OK. I am reading files from 1.7.3-4 and there is only Sebastien
name in it.
- debian/copyright seems to need an update.
Ouch, there are new assets not included in COPYING. I guess it's now blocked on
upstream.
Different author from the project.
Do we need to list everyone?
If there is a file with something like:
Copyright XXXX foo
License xxxx
It must be in debian/copyright. In the 1.7.3 upstream tarball:
$ /tmp/ghostwriter-1.7.3$ egrep -sriA25 "(copyright|public dom)" ./ | less
[...]
./src/spell_checker.h: * Copyright (C) 2009, 2010, 2012 Graeme Gott <graeme@gottcode.org>
./src/spell_checker.h: * Copyright (C) 2014 attercop
./src/spell_checker.h- *
./src/spell_checker.h- * This program is free software: you can redistribute it and/or modify
./src/spell_checker.h- * it under the terms of the GNU General Public License as published by
./src/spell_checker.h- * the Free Software Foundation, either version 3 of the License, or
./src/spell_checker.h- * (at your option) any later version.
[...]
./src/find_dialog.h: * Copyright (C) 2008, 2009, 2010, 2012 Graeme Gott <graeme@gottcode.org>
./src/find_dialog.h: * Copyright (C) 2014, 2015 wereturtle
./src/find_dialog.h- *
./src/find_dialog.h- * This program is free software: you can redistribute it and/or modify
./src/find_dialog.h- * it under the terms of the GNU General Public License as published by
./src/find_dialog.h- * the Free Software Foundation, either version 3 of the License, or
./src/find_dialog.h- * (at your option) any later version.
[...]
./src/sundown/autolink.h: * Copyright (c) 2011, Vicent Marti
./src/sundown/autolink.h- *
./src/sundown/autolink.h- * Permission to use, copy, modify, and distribute this software for any
./src/sundown/autolink.h- * purpose with or without fee is hereby granted, provided that the above
./src/sundown/autolink.h: * copyright notice and this permission notice appear in all copies.
./src/sundown/autolink.h- *
And more. They must go to debian/copyright.
The entry about 'Files: debian/*': the maintainer of the Debian package
here. debian/control says Sebastien CHAVAUX
As noone is the upstream the patch files also need - no must - a header.
See debian/patches/clean-deps.patch
dpkg-shlibdeps says it's a useless dependency # Looks like a description
--- a/ghostwriter.pro
+++ b/ghostwriter.pro
@@ -28,7 +28,7 @@
TEMPLATE = app
-QT += printsupport webkitwidgets widgets concurrent svg
+QT += printsupport webkitwidgets widgets concurrent
CONFIG -= debug
CONFIG += warn_on
The header:
Description: (above)
Author: foo
Last-Update: a date
https://dep-team.pages.debian.net/deps/dep3/ # Sample DEP-3 compliant headers
Regards,
Herbert
Reply to: