[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#902166: RFS: wifi-qr/0.1.0-1 [ITP, NMU]



Control: retitle -1 RFS: wifi-qr/0.1.0-1 [ITP]
Control: tag -1 + moreinfo

On Sat, 23 Jun 2018 07:20:41 +0630 "Ko Ko Ye`" <kokoye2007@gmail.com> wrote:
> Package: sponsorship-requests
> Severity: wishlist
> 
> Dear mentors,
> 
> I am looking for a sponsor for my package "wifi-qr"
> 
>  * Package name: wifi-qr
>  Version : 0.1.0-1
>  Upstream Author : kokoye2007@gmail.com
>  * URL : https://ubuntu-mm.net
>  * License : GPL3
>  Section : utils
> 
> It builds those binary packages:
> 
> wifi-qr- WiFi Share with QR and Connect with QR
> 
> To access further information about this package, please visit the
> following URL:
> 
> https://mentors.debian.net/package/wifi-qr
> 
> 
> Alternatively, one can download the package with dget using this command:
> 
> dget -x
> https://mentors.debian.net/debian/pool/main/w/wifi-qr/wifi-qr_0.1.0-1.dsc
> 
> More information about hello can be obtained from
> github.com/kokoye2007/wifi-qr
> 
> I fork idea from Xiaomi Phone Wifi Share and Password Share with QR and QR
> Scan with Connect.
> 
> 
> with regards
> *Ko Ko Ye`*

I'm neither going to sponsor your package nor doing a thorough check, but 
here's a list of problems that I found:

* Please remove "NMU" mark from your RFS title. The initial upload is always 
prepared by its future maintainer and it is never a NMU upload. Please refer 
to Debian's Developer's Reference for the exact meaning of NMU.

* Please use debhelper compat v11 (the latest one).

* Wifi-qr's long description contains too many English grammar mistakes. 
Please fix them.

* Please remove debian/files from your repository. That file is never part of 
packaging source.

* debian/manpage.1 should never be named as "manpage.1". Please refer to 
dh_installman(1) tool and its documentation for the right way of installing 
man pages into your package.

* You missed the most important runtime dependency (package "network-manager") 
in your debian/control file.

* You shall never manually call update-icon-caches in postinst script. The 
automatic triggers would deal with them for you.

* debian/postrm: ditto.

* debian/LICENSE: why are you putting the license file here? Is this the 
license for the whole repository or only for the debian/ directory?

* wifi-qr.desktop: Please remove "Encoding" key from the desktop file. This 
field is long deprecated.

* wifi-qr.desktop: Your "Keywords" field is invalid. Please refer to 
Freedesktop.org's Desktop File Specification for the correct grammar.

* wifi-qr.desktop: Using "sh -c ''" wrapper will immediately break your script 
since your script is written for bash but Debian's /bin/sh is often not bash.

Please fix the problems above or give proper explanations before proceeding to 
further steps. Thanks!

--
Regards,
Boyuan Yang

Attachment: signature.asc
Description: This is a digitally signed message part.


Reply to: