[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#883379: RFS: deepin-voice-recorder/1.3.6-1 [ITP]



control: tags -1 - moreinfo

On Thu, 1 Mar 2018 17:35:11 +0100 Gianfranco Costamagna
<locutusofborg@debian.org> wrote:
> control: owner -1 !
> control: tags -1 moreinfo
>
> grep DOCDIR . -R
> ./deepin-voice-recorder.pro:isEmpty(DOCDIR):DOCDIR=/usr/share/dman/deepin-voice-recorder
> ./deepin-voice-recorder.pro:manual.path = $$INSTROOT$$DOCDIR
>
>
> Why is the package installing stuff in /usr/share/dman? nothing in the archive uses such directory.
>

It's deepin manual system, and these files will be used by
https://github.com/linuxdeepin/deepin-manual to display a rich-text
help page.

> I'm reluctant to sponsor it, unless you provide some good explanation, and post a patch to upstream.
> (BTW the patch 0001 looks useless, please forward upstream).
>
> The other std-version, debhelper bump, and so on still apply
> also lintian
> I: deepin-voice-recorder: desktop-entry-lacks-keywords-entry usr/share/applications/deepin-voice-recorder.desktop

The 0001 and desktop-entry-lacks-keywords-entry have been reported to
upstream. I'd like to leave them as-is for the time being and wait for
next version fixing them. std-v, debhelper are bumped.

Uploaded to mentors.d.o

> Other stuff LGTM.
>


Reply to: