[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#889515: Review of persepolis



Dear Julien,

Thanks for reviewing my package. It was really helpful.
I fixed some of the mentioned issues and uploaded a new package to
mentors.debian.net.

There are still the following issues which I cannot fix:
no-upstream-changelog - Because there isn't any upstream changelog.
debian-watch-may-check-gpg-signature - Because the upstream files are
not signed.
testsuite-autopkgtest-missing - Because there isn't a suitable test in
the upstream at the moment.

--
Sincerely yours,
Moein Alinaghian


On Sat, 24 Feb 2018 09:29:04 +0100 Julien Puydt
<julien.puydt@laposte.net> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA512
>
> Control: tags -1 moreinfo
>
> Hi,
>
> I had a look at your packaging, and found the following:
>
> (-) debhelper 10 -- some advise 11
> (-) standard-version 4.1.2 -- we're now at 4.1.3
> (-) in d/copyright, you could share the license chunks:
> Files: foo
> Copyright: whatever
> License: GPL-3+
>
> Files: bar
> Copyright: whatever
> License: GPL-3+
>
> License: GPL-3+
>  Here comes the text, once!
>
>
> Then I tried to compile it, and saw what lintian had to say:
>
> $ lintian -I persepolis_3.0.1-1_amd64.changes --pedantic
> P: persepolis source: package-uses-old-debhelper-compat-version 10
> (see above: should fix)
> W: persepolis source: dep5-copyright-license-name-not-unique
> (paragraph at line 26)
> (see above: must fix)
> I: persepolis source: out-of-date-standards-version 4.1.2 (released
> 2017-11-30) (current is 4.1.3)
> (see above: should fix)
> I: persepolis source: testsuite-autopkgtest-missing
> (ok, it's not always possible)
> P: persepolis source: debian-watch-does-not-check-gpg-signature
> (ok, it's not always possible)
> P: persepolis: no-upstream-changelog
> (ok, it's not always possible)
> I: persepolis: extended-description-is-probably-too-short
> (should fix)
>
> I hope that helps,
>
> Snark on #debian-mentors
> -----BEGIN PGP SIGNATURE-----
>
> iQIzBAEBCgAdFiEEgS7v2KP7pKzk3xFLBMU71/4DBVEFAlqRIkkACgkQBMU71/4D
> BVGnNBAAmVMhKSXnaJGGE/EdRecoVJ+Jj2hufZHlXA9hW9jY3DlDxQLv9rANl2Pg
> lH+SPv4XDMOz92A698kfAE7tQkWpnOnirvvn+En6wT971WhL93IuFtjk4qWzo/8Y
> H4DdsrCBV777VGFpflX0aq2E0FBM9hk1BeUjrNiFrMTdUmwZPglDU7Mws3swVH7R
> jSh5ZDACh0NT20mYzr8VsLkDT4m184pRTOfn0ez0ND8HtfTun3g83KYMezXmhPye
> u7cFvCcjxOkhqLQv2OoPZrHd/c0WpZzJ5zFPw3chvCMiteaEzdspoZ1coOdF1CKE
> Jh+/mD1Kjdo00D4OsHD9ReOO+olKYPTz8mKlpezZJqA7yDmSWbMMsFEPJ322q5dG
> fD/GLDbsLBjqUXoCDU185ZfSz7dol58U00fqOwMmlXzP16q4iCxTf2wisMTLlJCx
> zxsDOokRshCmqT6T4mClfA1eblSxJAqQeqTBenfroa2N0HxDAvq8jRAw9GJy6RZF
> AmYY2/D+L+zhe3dD4xs2QgKlBkMlH2kR/8/ymRoDcfCk7bZpWdvL5yBSxjVNrIFu
> 1yhXjrqMUEO72xXDVTM+JvOZ/XBifWFgEq71GvQ27k/riAsWGNP1sLQgDkzRtlj6


Reply to: