[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#888312: RFS: streamlink/0.10.0+dfsg-1

On Thu, Jan 25, 2018 at 5:26 AM, Alexis Murzeau wrote:

> I am looking for a sponsor for my package "streamlink" for a new
> upstream version 0.10.0.


Some things that would be nice to fix at some point:

I'm surprised override_dh_installchangelogs is needed, the code seems
like it would match CHANGELOG.rst. Please build the package twice,
once with it and once without and then diffoscope the resulting binary

There is an incorrect statement in debian/rules, Debian has the
python3-iso3166 package.

Some grammar fixes for debian/rules:

s/need to have/needs to have/
s/Debian have/Debian has/

In future, I would suggest not mentioning check-all-the-things (or
lintian) in debian/changelog and instead mention what was fixed.

I would suggest using this as the donation link, since it won't go out
of date if they switch away from OpenCollective. It also mentions
Bountysource and individual team member donations.


I saw in the upstream code that they are manually building some URLs
with string concatenation. I think it would be much better to use a
URL class that knows how to encode parameters etc.



Reply to: