[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#874305: RFS: mitlm/0.4.2-1 -- MIT Language Modeling toolkit

X-Debbugs-CC: jwilk@debian.org
Control: tags -1 - moreinfo

Hi Adam and Tobias,
  thank you for having a look at this.

On 15/12/2017 14:09, Adam Borowski wrote:
> On Mon, Sep 04, 2017 at 10:49:36PM +0200, Giulio Paci wrote:
>> Dear Jakub,
>>   I am looking for a sponsor for an updated version of my package "mitlm"
> Apparently you forgot to CC jwilk; this RFS went only to the mentors
> mailinglist -- yet, upon seeing the first line, we assumed you want your
> usual sponsor.

You are right. I am CCing him now.

>> * Package name    : mitlm
>>   Version         : 0.4.2
> I'm afraid it fails to build:
> /<<PKGBUILDDIR>>/./configure: line 20515: AX_CXX_HEADER_TR1_UNORDERED_MAP: command not found
> /<<PKGBUILDDIR>>/./configure: line 20516: syntax error near unexpected token `noext,'
> /<<PKGBUILDDIR>>/./configure: line 20516: `AX_CXX_COMPILE_STDCXX_11(noext, optional)'

I added the autoconf-archive missing dependency.

On 04/01/2018 11:58, Tobias Frost wrote:
> Other notes: (Note that I did NOT a complete review)
> - Are you sure you want it uploaded to experimental? Why?

Indeed I am not sure, and actually prefer to have mitlm in unstable.

We decided to upload it to experimental, because of many uncertainties about both upstream development and about the package development (I was new to packaging when we
uploaded there).

As my long term goal is to have typical "development" packages for speech recognition and speech synthesis in Debian, I would really like to see mitlm in unstable.

> - d/compat could be bumped.


> - (S-V has increased in the meantime too, when over it you might want
> to update that to the latest)


> - maybe consider switching to debhelper (and dh_autoreconf). I'm pretty
> sure that will simplify d/rules a lot. (This would be whishlist entry
> of mine, not required at all)

Considered and done. :-)

> Please fix the FTBFS (and if you want the stuff above), then remove the
> moreinfo when ready!

Done by adding the missing dependency.

Reply to: