[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#872147: RFS: lirc/0.10.0-2 NMU



On Wed, 16 Aug 2017 02:01:12 +0500 Andrey Rahmatullin <wrar@debian.org> wrote:

> On Tue, Aug 15, 2017 at 10:32:55PM +0200, Alec Leamas wrote:
> > > Why does the report title say "NMU"?
> >
> > Perhaps it shouldn't - large parts of the debian workflow is still a mystery
> > for me.
> Please read
> https://www.debian.org/doc/manuals/developers-reference/ch05.en.html#nmu
> If you are the package maintainer you don't do NMUs, but plain uploads.

Done, got it. I was confused by the fact that while I am the maintainer, I havn't done the uploads myself.

> > > How are those two upstream bugs fixed?
> >
> > They was fixed by the experimental 0l.10.0-rc3 upstream release, which
> > eventually became 0.10.0 by upstream and pushed to sid as 0.10.0-1. This
> > should have been mentioned in -1, but was not, hence the -1 note.
> If they are fixed in an old version, why are they mentioned in this upload
> entry? Please read
> https://www.debian.org/doc/manuals/developers-reference/ch06.en.html#bpp-debian-changelog

Just because I missed to document it in the correct -1 entry. Would it be better to update the -1 changelog entry?

> > > I haven't looked at the package itself, but wtf is happening in prerm? > > Removing files not owned by the package any more (but left on install to
> > niot remove anything user-edited).
> Why are they not owned by the package?

Basically because the package from 0.9.4 is systemd-centric.

> Obsolete conffiles should be
> removed by dpkg-maintscript-helper rm_conffile.

Looking at rm_conffile at [1] this doesn't look relevant here (?) The current code is basically a left-over from the disruptive change from 0.9.0 which is several versions beyond current version. So the checksums from previous version is not available. Current code just makes sure everything is cleaned up on a final remove.

> I've also noticed the priority: extra field, which means when you updated
> Standards-Version to 4.0.1 in the previous upload you haven't actually
> consulted
> https://www.debian.org/doc/debian-policy/upgrading-checklist.html

Indeed, I was not aware of it. Checking, updated Priority: to optional.

Thanks for pointers to relevant documents, very helpful! Uploaded a new version to mentors, for now with irrelevant sources included. Have not been able to verify the upload, but sends this reply anyway - will be way for the day and cannot send it until this evening otherwise.


Cheers!

--alec


Reply to: