[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#869692: RFS: cyclograph/1.9.0-1

On the git server you can find a new commit with all the changes requested.

2017-07-29 19:34 GMT+02:00 Andrey Rahmatullin <wrar@debian.org>:
> * The package now depends on python3
> Which package?
It's both a build dependency and a runtime dependency of "cyclograph"
the main binary package. The cyclograph-qt5 and cyclograph-gtk3 binary
packages depend on cyclograph, so they all depend on python3.
Please take a look at the new changelog and see if this is now clear.
> * The package now uses dh-python in combination with python3-setuptools
> "in combination"?
My understanding is that pybuild, provided by the dh-python package,
needs the setuptools for python3, but, since it cannot know if python2
or python3 is used, the correct B-D has to be manually added.
Please take a look at the new changelog and see if this is now clear.
> * Added cyclograph-qt5 ui
> Not clear that cyclograph-qt5 is a new subpackage.
Ok, last entry in the changelog was about the removal of
cyclograph-qt4, but I can understand that a longer description in the
changelog is more useful.
> * Debhelper compat version updated to 10
> It's "compat level", see debhelper(7).
Sorry for that. I confused the Debhelper version, with the compatibility level.
> * Updated Standards to 4.0.0
> It's "Standards-Version", and it's customary to add "(no change needed)"
> if an upgrade to the new version didn't require anything (I assume you've
> read the upgrade checklist?).
I read the checklist[1] and I didn't find anything to be done.
"(no change needed)" added.
> * Updated gtk to webkit2 version 4.0
> Not clear what is "gtk" here.
This is the "cyclograph-gtk3".
> * Added vcs field to debian/control
> It's not a "vcs" field but Vcs-Git and Vcs-Browser.
> You also didn't mention the switch to pybuild.

 [1] https://www.debian.org/doc/packaging-manuals/upgrading-checklist.txt

Reply to: